Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images won't load if they have focus when Bramble starts #494

Open
humphd opened this issue Nov 2, 2015 · 11 comments
Open

Images won't load if they have focus when Bramble starts #494

humphd opened this issue Nov 2, 2015 · 11 comments
Assignees
Labels

Comments

@humphd
Copy link

humphd commented Nov 2, 2015

STR:

  • drag and drop an image into your filesystem
  • select the image in the file tree
  • refresh the page
  • notice the image is a 404
  • select the index.html
  • reload the page
  • select the image from the file tree
  • notice it works fine when not selected on startup

screenshot 2015-11-02 15 13 08

@humphd
Copy link
Author

humphd commented Nov 16, 2015

This is only an issue in Bramble vs. Thimble, it seems, because in Thimble we always try to load an HTML file.

@gideonthomas gideonthomas added the P3 label Jan 8, 2016
@humphd
Copy link
Author

humphd commented Mar 11, 2017

Please test my PR in #625 with this bug, I might have fixed it when I rewrote that code.

@peiying16
Copy link

peiying16 commented Mar 11, 2017

I want to test it. I use following commands to download your branch, where are the codes it downloads to? This is the first time for me to test others' code.

git remote add "humphd" https://github.com/humphd/brackets.git
git fetch humphd

@humphd
Copy link
Author

humphd commented Mar 13, 2017

git remote add humphd https://github.com/humphd/brackets.git
git fetch humphd
git checkout livedev-fixes

@peiying16
Copy link

peiying16 commented Mar 13, 2017

I checkout to your branch, but I can't load the page. Error message is here.
err

@peiying16
Copy link

Here are my branchs and remote
git

@humphd
Copy link
Author

humphd commented Mar 14, 2017

I would clear your cache. Let's discuss in class tomorrow too.

@humphd
Copy link
Author

humphd commented Mar 14, 2017

@peiying16 thanks for altering me to this--it was a bug in my code. I've pushed a new commit on my PR which fixes it. Do you mind trying again? Thanks for letting me know about this, I totally missed it!

@peiying16
Copy link

@humphd Hello, I try your PR. Now I can load the page successfully, but it doesn't fix this issue. It is still 404
image

@humphd
Copy link
Author

humphd commented Mar 16, 2017

OK, this is helpful. Thank you. I think it's something to do with it trying to load an ImageView vs. an HTML Live Document on startup, and not using a rewritten Blob URL. We'll have to debug this separate to what you're doing.

Thanks for you testing, I just hoped it would solve this bug, too.

@humphd humphd self-assigned this Apr 19, 2017
@humphd
Copy link
Author

humphd commented Apr 19, 2017

NOTE: I have a fix for this in my work for #725, see a122b49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants