Fix #546 - Use sw-precache to make Bramble offline ready #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ignoreUrlParametersMatching: [/./] | ||
| }; | ||
|
|
||
| swPrecache.write(Path.join(rootDir, 'bramble-sw.js'), config, function(err) { |
There was a problem hiding this comment.
|
Few questions otherwise looks good to merge |
|
@gideonthomas, I've updated things, you OK with it now r? |
|
r+ |
Update docs Review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, I can run Bramble offline. It's really cool. The major downside to this is that it requires us to keep a static list of files in order to "prime" the cache, and register handlers for the Service Worker to respond to when URLs are requested. I don't see us adding a lot of files, but it's something we'll have to keep an eye on. I need to document this, too.
This probably needs another bit of tidying up, but it's pretty close.
cc @gideonthomas