Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
humphd committed Apr 12, 2016
1 parent 46deab8 commit 2179720
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ Even if you're not a committer, you're still welcome to give feedback on any pul

## Adding New Files

When run in production (i.e., the resulting `dist/` dir from running `grunt build-browser`),
When run in production (i.e., the resulting `dist/` dir from running `grunt build-browser-compressed`),
Bramble uses a Service Worker to cache and serve the app offline. In order to do this, the
`swPrecache` grunt task generates a Service Worker ready to cache and serve all the necessary
files. This file list is generated statically at build time based on the contents of the
Expand Down
11 changes: 7 additions & 4 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -644,12 +644,15 @@ module.exports = function (grunt) {
'replace:ternDefs',
'requirejs:iframe',
'exec:localize-dist',
'uglify',
'swPrecache'
'uglify'
]);

// task: build dist/ for browser, pre-compressed with gzip
grunt.registerTask('build-browser-compressed', ['build-browser', 'compress']);
// task: build dist/ for browser, pre-compressed with gzip and SW precache
grunt.registerTask('build-browser-compressed', [
'build-browser',
'compress',
'swPrecache'
]);

// task: undo changes to the src/nls directory
grunt.registerTask('unlocalize', ['exec:clean-nls']);
Expand Down

0 comments on commit 2179720

Please sign in to comment.