Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send owner email for override of takedown -> ignore #22944

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

eviljeff
Copy link
Member

Fixes: mozilla/addons#15246

Description

Small change to treat IGNORE as a valid action that could be used to override a takedown (DISABLE_ADDON, etc) decision.

Context

See issue - mainly this was because of how we treated overrides - i.e. as the same as appeals, where Ignore isn't a valid grant appeal policy.

Testing

  • Report some content to Cinder for Abuse
  • in Cinder reject/disable/ban the content with a takedown related policy
  • reply the webhook payload locally
  • see the developer and reporter got emails saying the content was removed
  • override the decision in Cinder to Ignore
  • reply the webhook payload loclly
  • see the developer gets a new email explaining we changed or minds

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

Copy link

sentry-io bot commented Dec 12, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/olympia/abuse/models.py

Function Unhandled Issue
notify_reviewer_decision ConnectionError: b'\n\n\n<title>502 ... ...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

@eviljeff eviljeff marked this pull request as draft December 12, 2024 18:28
@eviljeff eviljeff marked this pull request as ready for review December 13, 2024 10:39
@eviljeff eviljeff requested review from a team and diox and removed request for a team December 13, 2024 10:39
@diox diox self-requested a review December 16, 2024 13:00
@eviljeff eviljeff merged commit 7f52824 into mozilla:master Dec 17, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Overriding from DISABLE_ADDON to IGNORE isn't supported properly
2 participants