Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Overriding from DISABLE_ADDON to IGNORE isn't supported properly #15246

Closed
1 task done
eviljeff opened this issue Dec 12, 2024 · 2 comments · Fixed by mozilla/addons-server#22944
Closed
1 task done
Assignees
Milestone

Comments

@eviljeff
Copy link
Member

eviljeff commented Dec 12, 2024

What happened?

A takedown (e.g. AMO_DISABLE_ADDON) decision overridden with AMO_IGNORE doesn't send any email to the reporter or content owner when the content is restored. That the reporter doesn't get an email is probably okay; that the content owner doesn't is bad.

Explanation: In general we don't send any emails to the content owner for an Ignore action on the back of abuse reports. We treat overrides similarly to appeals, and an appeal resolution of Ignore was not assumed to be a valid scenario. For overrides, it is possible though.

What did you expect to happen?

I expected an email to go to the owner to tell them we changed our mind and restored the content we disabled.

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link

I verified this with Cinder dev queues with both sub-policies available

I get the same result as for disable plus override with Approve which has been tested. To summarize:

  • at disable content is taken down and emails are sent to the reporter and developer (both the expected emails)
  • then going to override with Developer feedback or Not enough information I'll get an email sent to the developer

amo ignore override email

previous appeal sent to developer

  • also checked if the appeals are sent prior to an override attempt then there is no possibility to override from Cinder ✅

  • I think there is a Cinder issue when it comes to policies in the Override menu, for example for an add-on there are sub-policies that would escalate to AMO, such as Closed user group from Content or both sub-policies from Privacy Policy. Checking different entities same's for ratings,I see Escalate with Escalate to AMO and Escalate to Legal. -> let me know if I should file a Lindie issue

example with the ratings:

override decisions for ratings

@ioanarusiczki
Copy link

We've decided to leave this as it is (the last point from my comment above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants