Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time inefficient loop in not_blocked_items #22862

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Remove time inefficient loop in not_blocked_items #22862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/olympia/blocklist/mlbf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,11 @@ def not_blocked_items(self) -> List[str]:
.order_by('id')
.values_list('addon__addonguid__guid', 'version')
)
blocked_items = set(self.blocked_items + self.soft_blocked_items)
# even though we exclude all the version ids in the query there's an
# edge case where the version string occurs twice for an addon so we
# ensure not_blocked_items contain no blocked_items or soft_blocked_items.
return [
item
for item in not_blocked_items
if item not in self.blocked_items + self.soft_blocked_items
]
return [item for item in not_blocked_items if item not in blocked_items]


class MLBF:
Expand Down
Loading