-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove time inefficient loop in not_blocked_items #22862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you squash your commits to get a single commit in this PR? I know GitHub will do it eventually but it'd be easier to navigate the changes locally.
Ok @willdurand let's do it your way. I have things to say about your feedback but PR comments is not the place, especially when the goal here is to "unbreak prod on the short term" |
Remove test Revert reuse of reusable function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+, thanks
Remove test Revert reuse of reusable function
Relates to: mozilla/addons#15170
Description
Removes time inefficient loop in get_not_blocked_items by filtering from a once created set instead of an inlined list
Context
This patch adds a slow test 20 seconds that can be isolated from the rest of our tests in a follow up PR
Testing
CI passes, this PR will be verified on staging as well.
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.