Build docker image with buildx to support new Dockerfile syntax #21960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
force-pushed
the
ADDSRV-744
branch
3 times, most recently
from
8e45574 to
d8a8420
Compare
eviljeff
reviewed
Mar 1, 2024
.circleci/config.yml
Outdated
Comment on lines
661
to
662
| # Uncomment if you want to test the docker build | ||
| - build-image |
There was a problem hiding this comment.
it's already uncommented though. - is this comment accurate?
There was a problem hiding this comment.
Wanted to confirm it actually works. I'll remove the commit reverting back to commented out before merging.
KevinMind
changed the title
eviljeff
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#9528
Description
Explicitly use
docker buildx buildto ensure buildkit flags and syntax are available during local/ci builds. We run the make command in CI to ensure the same command is executed in both environments. This is also essentially compatible with that is executed in the github action build.Context
#21914 broke the docker build in circleci, this went unnoticed because the build only runs on master and the command was simple and using the same docker build as we have in the locale make command
build_docker_image. There were differences in arguments, but it was assumed that docker build would support buildx context... that was wrong.Testing
You can test by adding the
-build-imagejob to a workflow. It is enabled in this commit: d8a8420731e2b4ca7d83fbb98befc8f8817e5478Which will be removed before merging.