Show inline linter messages in the compare view #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=========================================
+ Coverage 97.14% 97.2% +0.05%
=========================================
Files 35 35
Lines 701 715 +14
Branches 157 159 +2
=========================================
+ Hits 681 695 +14
Misses 19 19
Partials 1 1
Continue to review full report at Codecov.
|
|
This is the issue to fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements inline linter messages which is the final part to fix #314
In http://localhost:3000/en-US/compare/494431/versions/1532144...1532144/ you can click on
common.jsto see an inline message.Example from storybook: