-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View linter messages in the compare view for versions #314
Comments
We will need a way to link into the |
The linter messages shown will be for the newer version in the compare view |
In the + getWidgets = (hunks) => {
+ return (
+ this.state.changesWithComments
+ .reduce((widgets, change) => {
+ const changeKey = getChangeKey(change);
+
+ return {
+ ...widgets,
+ [changeKey]: (
+ <Comment
+ comment={
+ change.lineNumber === 39
+ ? null
+ : { content: 'This is not needed.' }
+ }
+ />
+ ),
+ };
+ }, {})
+ );
+ }; It also needs The diff above ha a list of comments stored in |
I think we added |
User story:
This will be similar to showing linter messages in the file viewer: #41
Example from the current site:
The text was updated successfully, but these errors were encountered: