Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Review of Issue #3: Traversal of the space of train/test splits #161

Closed

Conversation

Bolaji61
Copy link
Contributor

@Bolaji61 Bolaji61 commented Apr 6, 2020

One consideration for further exploration is how you would investigate the statement that 0.4/0.6 is an anomaly in your conclusions. Perhaps multiple runs with a variable random seed to see how the performance at different split ratios is affected by the random assignment into test vs train portions is worth investigating.

Above was the previous review made by @mlopatka in #101
I have researched on the above review and in this PR, I have been able to analyze the effect of different random state numbers (in the train_test_split function) on the performance of the model.

@Bolaji61 Bolaji61 changed the title Fixed Issue #3: Traversal of the space of train/test splits Fixed Review of Issue #3: Traversal of the space of train/test splits Apr 7, 2020
@mlopatka
Copy link
Contributor

Thank you for the PR! Our apologies for the (long) delay in getting to review this contribution.
We took a pause from reviewing contributions made as part of the outreachy application process in order to prioritize planning the roadmap of the PRESC project moving forward.

As a consequence of this delay, some outstanding PRs exhibit a degree of dissociation from the master branch that makes conflict resolution very complicated. We are capturing contributions that meaningfully contribute to the current direction of the project goals in an archival repo to help us systematically integrate the useful parts into the PRESC master branch. In some cases, this content will be merged and then migrated, and in some cases the specific content will be merged into the archival repo via a separate PR.

Once again, a sincere thanks for you interest and contribution to the PRESC project.

@mlopatka mlopatka closed this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants