Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3, Traversal of the space of train/test splits. #101

Merged
merged 4 commits into from
Mar 30, 2020

Conversation

Bolaji61
Copy link
Contributor

Here, I have been able to create a traversal() function that takes estimator and dataset as parameters and returns a result of different test sizes and their corresponding accuracy score based on the Logistic Regression estimator used.

However, I do not yet understand what is meant by "a table of splits with multiple metric values per split" as mentioned in issue #3 , I'll appreciate if this is further clarified.

@Bolaji61 Bolaji61 changed the title WIP: Traversal of the space of train/test splits, issue #3. Traversal of the space of train/test splits, issue #3. Mar 24, 2020
@Bolaji61
Copy link
Contributor Author

I have fixed issue #3, by investigating and explaining on how much the performance metrics/scores depend on the choice of train/test split proportions using Logistic Regression model

@Bolaji61 Bolaji61 changed the title Traversal of the space of train/test splits, issue #3. Fixed #3, Traversal of the space of train/test splits. Mar 25, 2020
Copy link
Contributor

@mlopatka mlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
One consideration for further exploration is how you would investigate the statement that 0.4/0.6 is an anomaly in your conclusions. Perhaps multiple runs with a variable random seed to see how the performance at different split ratios is affected by the random assignment into test vs train portions is worth investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants