feat: refactor sync timestamp #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by: Phil Jenvey <[email protected]> Issue #74
bbangert
force-pushed
the
refactor/sync-timestamp
branch
from
6a6f895
to
194040e
Compare
pjenvey
approved these changes
Nov 6, 2018
philbooth
approved these changes
Nov 7, 2018
| /// Create a `SyncTimestamp` from an i64 | ||
| /// | ||
| /// Only called from the db module | ||
| pub(super) fn from_i64(val: i64) -> Result<Self, DbError> { |
There was a problem hiding this comment.
Ah, it's a shame the TryFrom trait is nightly-only, it would have been perfect for this right?
There was a problem hiding this comment.
Yup, I was wishing that as we added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by: Phil Jenvey [email protected]
Issue #74