New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup db types #74

Closed

2 of 3 tasks

pjenvey opened this issue Oct 29, 2018 · 1 comment

Assignees

Labels

Member

pjenvey commented Oct 29, 2018 •

edited

Loading

Cleanup many of the various XXX comments around type signatures around the mysql db

fixing modified/'sizes' to become u64s
fix the user_id column to be 64 bits (it's a BigInt in token server yet a regular Int in server-syncstorage for some reason)
may want to revisit handling of u64s passed into the database: they must be casted to i64s so we may want to bounds check them beforehand (fixed for user_id)

pjenvey added the enhancement label

pjenvey self-assigned this

bbangert mentioned this issue

feat: refactor sync timestamp #82

Merged

bbangert added a commit that referenced this issue


          feat: refactor sync timestamp

194040e

Co-authored by: Phil Jenvey <[email protected]>

Issue #74

pjenvey added backlog labels

pjenvey removed the 🔄 Durable Sync label

tublitzed removed the backlog label

pjenvey mentioned this issue

[mysql] Make the userid column a BIGINT #470

Closed

Member Author

pjenvey commented Mar 6, 2020

AFAICT item #1 (fixing modified/'sizes' to become u64s) already happened?

Extracted #2 into #470, so closing.

pjenvey closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment