Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

chore: move disabling of debug-images into code #549

Merged
merged 2 commits into from
May 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ rand ="0.8"
regex = "1"
reqwest = { version = "0.11", features = ["json"] }
serde = "1"
sentry = { version = "0.30", default-features = false, features = ["backtrace", "contexts", "panic", "transport"] }
sentry = "0.30"
sentry-backtrace = "0.30"
serde_json = "1"
scopeguard = "1.1"
Expand Down
9 changes: 7 additions & 2 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,18 @@ async fn main() -> Result<(), Box<dyn Error>> {
Arc::new(sentry::transports::CurlHttpTransport::new(&options))
as Arc<dyn sentry::internals::Transport>
};
*/
let _sentry = sentry::init(sentry::ClientOptions {
*/
// Disable debug-images: it conflicts w/ our debug = 1 rustc build option:
// https://github.com/getsentry/sentry-rust/issues/574
let mut opts = sentry::apply_defaults(sentry::ClientOptions {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bleh.

I get it, and 👍🏻, but bleh.

(this seems like it really should be something configurable in the collector.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed 😃

// Note: set "debug: true," to diagnose sentry issues
// transport: Some(Arc::new(curl_transport_factory)),
release: sentry::release_name!(),
..sentry::ClientOptions::default()
});
opts.integrations.retain(|i| i.name() != "debug-images");
opts.default_integrations = false;
let _sentry = sentry::init(opts);

debug!("Starting up...");

Expand Down