This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
chore: move disabling of debug-images into code #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can keep the crate's default-features in Cargo.toml (follow up to 976da76, thanks JR)
jrconlin
reviewed
May 5, 2023
| */ | ||
| // Disable debug-images: it conflicts w/ our debug = 1 rustc build option: | ||
| // https://github.com/getsentry/sentry-rust/issues/574 | ||
| let mut opts = sentry::apply_defaults(sentry::ClientOptions { |
There was a problem hiding this comment.
bleh.
I get it, and 👍🏻, but bleh.
(this seems like it really should be something configurable in the collector.)
jrconlin
approved these changes
May 5, 2023
ncloudioj
approved these changes
May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
GitHub: sentry-rust#574
Description
so we can keep the crate's default-features in Cargo.toml
(follow up to 976da76, thanks JR)
PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title