Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

bug: fix _expiry() function to use seconds #1148

Merged
merged 1 commit into from
Mar 8, 2018
Merged

bug: fix _expiry() function to use seconds #1148

merged 1 commit into from
Mar 8, 2018

Conversation

jrconlin
Copy link
Member

@jrconlin jrconlin commented Mar 6, 2018

Also enforce expiry on router records

Closes #1073

Also enforce expiry on router records

Closes #1073
@jrconlin
Copy link
Member Author

jrconlin commented Mar 6, 2018

Please refer to #1073 (comment) for why filterExpression is not being used here.

FWIW, the core problem is that if the key identified by ExclusiveStartKey can't be found (because, say the record expired and was dropped by the database), the query fails with a Validation error and the backfill fails.

@codecov-io
Copy link

codecov-io commented Mar 6, 2018

Codecov Report

Merging #1148 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1148   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          60      60           
  Lines        9923    9938   +15     
======================================
+ Hits         9923    9938   +15
Impacted Files Coverage Δ
autopush/utils.py 100% <ø> (ø) ⬆️
autopush/db.py 100% <100%> (ø) ⬆️
autopush/tests/test_integration.py 100% <100%> (ø) ⬆️
autopush/tests/test_db.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75b96d...cfcad77. Read the comment docs.

Copy link
Member

@pjenvey pjenvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so snafu. nice catch

@bbangert bbangert merged commit 8d2021e into master Mar 8, 2018
@bbangert bbangert deleted the feat/1073 branch March 8, 2018 01:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants