Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Switch db.py boto3 get and query calls to use FilterExpression for expiry #1073

Closed
jrconlin opened this issue Nov 10, 2017 · 3 comments
Closed

Switch db.py boto3 get and query calls to use FilterExpression for expiry #1073

jrconlin opened this issue Nov 10, 2017 · 3 comments
Assignees
@jrconlin

Comments

@jrconlin
Copy link
Member

see comments in db.py
TODO: once expiry is properly integrated, use FilterExpression

Blocked until JAN 2018 to allow for sufficient numbers of channels to expire from rollover.
@jrconlin jrconlin self-assigned this Nov 10, 2017
@jrconlin jrconlin mentioned this issue Nov 10, 2017
Closed
@pjenvey pjenvey added the blocked label Dec 6, 2017
@jrconlin
Copy link
Member Author

jrconlin commented Dec 7, 2017

Blocked on #1081

@jrconlin
Copy link
Member Author

jrconlin commented Mar 6, 2018

Note, due to AWS query precedence, limit and filterExpression may result in no results being returned. While this may be a legitimate, backfilling may not always be possible, as the LastEvaluatedKey may have expired, and been dropped resulting in the backfill failing.

For now, going to drop the filterExpression and just presume that expiration works.

jrconlin added a commit that referenced this issue Mar 6, 2018
@jrconlin
bug: fix _expiry() function to use seconds
cfcad77 
Also enforce expiry on router records

Closes #1073
@jrconlin jrconlin mentioned this issue Mar 6, 2018
Merged
@pjenvey
Copy link
Member

pjenvey commented Mar 6, 2018

(The above referenced TODO was never committed but can seen here: https://github.com/mozilla-services/autopush/pull/1072/files )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjenvey @jrconlin @bbangert