This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: Fix diagnostic cli to handle tuple args #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also we were inconsistent about passing `current_month` when registering `webpush` protocol entities. While not strictly an error now, it could cause issues later if we do stricter lookups. Closes #1096
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
+ Coverage 99.71% 99.71% +<.01%
==========================================
Files 58 58
Lines 9278 9284 +6
==========================================
+ Hits 9252 9258 +6
Misses 26 26
Continue to review full report at Codecov.
|
pjenvey
approved these changes
Dec 5, 2017
bbangert
approved these changes
Dec 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also we were inconsistent about passing
current_monthwhen registeringwebpushprotocol entities. While not strictly an error now, it couldcause issues later if we do stricter lookups.
Closes #1096