Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Diagnostic CLI has not been updated to accept tuple of arguments #1096

Closed
jrconlin opened this issue Dec 5, 2017 · 0 comments
Closed

Diagnostic CLI has not been updated to accept tuple of arguments #1096

jrconlin opened this issue Dec 5, 2017 · 0 comments
Assignees
@jrconlin

Comments

@jrconlin
Copy link
Member

jrconlin commented Dec 5, 2017

endpoint_diagnostic argument parser fails to handle new shared_config_files tuple.
jrconlin added a commit that referenced this issue Dec 5, 2017
@jrconlin
bug: Fix diagnostic cli to handle tuple args
ae89a21 
Also we were inconsistent about passing `current_month` when registering
`webpush` protocol entities. While not strictly an error now, it could
cause issues later if we do stricter lookups.

Closes #1096
@jrconlin jrconlin mentioned this issue Dec 5, 2017
Merged
@jrconlin jrconlin self-assigned this Dec 5, 2017
jrconlin added a commit that referenced this issue Dec 7, 2017
@jrconlin
bug: Fix diagnostic cli to handle tuple args
7acbcec 
Also we were inconsistent about passing `current_month` when registering
`webpush` protocol entities. While not strictly an error now, it could
cause issues later if we do stricter lookups.

Closes #1096
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrconlin @bbangert