Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Revert registration's critical_failure UAID check #880

Closed
pjenvey opened this issue Apr 24, 2017 · 0 comments · Fixed by #881
Closed

Revert registration's critical_failure UAID check #880

pjenvey opened this issue Apr 24, 2017 · 0 comments · Fixed by #881
Assignees
@pjenvey
Labels
bug p1

Comments

@pjenvey
Copy link
Member

pjenvey commented Apr 24, 2017

This is causing more trouble than it's worth for clients, e.g.:

https://bugzilla.mozilla.org/show_bug.cgi?id=1358689

Reregistering should clear out these errors but the critical_failure prevents them from doing so.
@pjenvey pjenvey self-assigned this Apr 24, 2017
pjenvey added a commit that referenced this issue Apr 24, 2017
@pjenvey
fix: revert registration's strict critical failure check
caf2ed8 
was causing more trouble than it's worth for clients

also add an already passing test for #867 (fixed in b1312db)

fixes #880, #867
@pjenvey pjenvey mentioned this issue Apr 24, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: revert registration's strict critical failure check mozilla-services/autopush
2 participants
@pjenvey @bbangert