Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Don't send empty string for required param #867

Closed
bbangert opened this issue Apr 12, 2017 · 1 comment
Closed

Don't send empty string for required param #867

bbangert opened this issue Apr 12, 2017 · 1 comment
Assignees
Labels

Comments

@bbangert
Copy link
Member

Per Sentry issue, https://sentry.prod.mozaws.net/operations/autopush-prod/issues/383827/

ValidationException: ValidationException: 400 Bad Request
{u'__type': u'com.amazon.coral.validate#ValidationException', u'message': u'ExpressionAttributeValues contains invalid value: One or more parameter values were invalid: An AttributeValue may not contain an empty string for key :router_data'}

Traceback:

ValidationException: ValidationException: 400 Bad Request
{u'__type': u'com.amazon.coral.validate#ValidationException', u'message': u'ExpressionAttributeValues contains invalid value: One or more parameter values were invalid: An AttributeValue may not contain an empty string for key :router_data'}
  File "twisted/python/threadpool.py", line 246, in inContext
    result = inContext.theWork()
  File "twisted/python/threadpool.py", line 262, in <lambda>
    inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
  File "twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
  File "autopush/db.py", line 292, in wrapper
    return func(self, *args, **kwargs)
  File "autopush/db.py", line 718, in register_user
    return_values="ALL_OLD",
  File "boto/dynamodb2/layer1.py", line 2765, in update_item
    body=json.dumps(params))
  File "boto/dynamodb2/layer1.py", line 2842, in make_request
    retry_handler=self._retry_handler)
  File "boto/connection.py", line 954, in _mexe
    status = retry_handler(response, i, next_sleep)
  File "boto/dynamodb2/layer1.py", line 2882, in _retry_handler
    response.status, response.reason, data)
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Apr 12, 2017
@bbangert bbangert added the ready label Apr 19, 2017
@pjenvey pjenvey self-assigned this Apr 24, 2017
pjenvey added a commit that referenced this issue Apr 24, 2017
was causing more trouble than it's worth for clients

also add an already passing test for #867 (fixed in b1312db)

fixes #880, #867
@pjenvey
Copy link
Member

pjenvey commented Apr 25, 2017

already fixed in #870, test added in #881

@pjenvey pjenvey closed this as completed Apr 25, 2017
@pjenvey pjenvey removed the ready label Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants