Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix LogBeginner usage to avoid its log event buffering #786

Closed
pjenvey opened this issue Jan 18, 2017 · 0 comments · Fixed by #787
Closed

fix LogBeginner usage to avoid its log event buffering #786

pjenvey opened this issue Jan 18, 2017 · 0 comments · Fixed by #787
Assignees
@pjenvey
Labels
bug p1
Milestone
PUSHSVC-0: quality

Comments

@pjenvey
Copy link
Member

pjenvey commented Jan 18, 2017 •
edited
Loading

twisted's LogBeginner is needlessly buffering 65k of old log events for later replaying. Our log events are not small (and rich w/ dicts of dicts of str/unicode). Raw log events also reference their Logger who emitted the message, and Loggers are produced for every class instance (twisted's Logger.__get__ does this as a feature).

This is a lot of garbage, definitely resulting in more memory usage and a lot more work for pypy's incremental GC to track it all.
@pjenvey pjenvey added this to the PUSHSVC-0: quality milestone Jan 18, 2017
@pjenvey pjenvey self-assigned this Jan 18, 2017
pjenvey added a commit that referenced this issue Jan 19, 2017
@pjenvey
fix: prefer the LogBeginner observer entry point
dc64f8a 
otherwise its buffer pointlessly keeps around 65k old log message
events for replaying

fixes #786
@pjenvey pjenvey mentioned this issue Jan 19, 2017
Merged
@pjenvey pjenvey mentioned this issue Jan 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

Successfully merging a pull request may close this issue.

fix: prefer the LogBeginner observer entry point mozilla-services/autopush
2 participants
@pjenvey @jrconlin