Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

fix LogBeginner usage to avoid its log event buffering #85

Closed
pjenvey opened this issue Jan 27, 2017 · 0 comments · Fixed by #86
Closed

fix LogBeginner usage to avoid its log event buffering #85

pjenvey opened this issue Jan 27, 2017 · 0 comments · Fixed by #86
Assignees
@pjenvey
Labels
bug p1
Milestone
PUSHSVC-0: quality

Comments

@pjenvey
Copy link
Member

pjenvey commented Jan 27, 2017

aplt suffers from the same memory leak recently discovered and fixed in autopush:

mozilla-services/autopush#786
@pjenvey pjenvey added this to the PUSHSVC-0: quality milestone Jan 27, 2017
@pjenvey pjenvey self-assigned this Jan 27, 2017
pjenvey added a commit that referenced this issue Jan 27, 2017
@pjenvey
fix: prefer the startLoggingWithObserver (LogBeginner) entry point
6d1851a 
otherwise its buffer pointlessly keeps around 65k old log message
events for replaying

fixes #85
pjenvey added a commit that referenced this issue Jan 27, 2017
@pjenvey
fix: prefer the startLoggingWithObserver (LogBeginner) entry point
71a0a78 
otherwise its buffer pointlessly keeps around 65k old log message
events for replaying

fixes #85
@pjenvey pjenvey mentioned this issue Jan 27, 2017
Merged
bbangert pushed a commit that referenced this issue Jan 27, 2017
@pjenvey @bbangert
fix: prefer the startLoggingWithObserver (LogBeginner) entry point
4802d24 
otherwise its buffer pointlessly keeps around 65k old log message
events for replaying

fixes #85
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug p1
Projects
None yet
Milestone
PUSHSVC-0: quality
2 participants
@pjenvey @bbangert