Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor fixes for GAR deploy CircleCI jobs #764

Merged
merged 9 commits into from
Sep 5, 2024
Merged

fix: minor fixes for GAR deploy CircleCI jobs #764

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
017b132
fix: fixed docker tag command
emaydeck-mozilla Sep 4, 2024
26169ea
test: added debug scenario to conditionals
emaydeck-mozilla Sep 4, 2024
f551d30
test: try testing only the tag and push portions of the workflow
emaydeck-mozilla Sep 4, 2024
8d428d8
fix: pulling image from cache now
emaydeck-mozilla Sep 4, 2024
72e8204
test: try using /tmp/cache mount point
emaydeck-mozilla Sep 4, 2024
f350f26
test: only use /tmp in gar jobs
emaydeck-mozilla Sep 4, 2024
93c227b
test: trying a different image name when pushing
emaydeck-mozilla Sep 4, 2024
94e9a0d
chore: remove debug items in gar workflows
emaydeck-mozilla Sep 4, 2024
2c3633a
chore: use param name instead of hardcoding "build"
emaydeck-mozilla Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,11 @@ jobs:
use_oidc: true
workload_identity_pool_id: GCP_OIDC_WIP_ID
workload_identity_pool_provider_id: GCP_OIDC_WIP_PROVIDER_ID
- attach_workspace:
at: /tmp/cache
- run:
name: Restore Docker image cache
command: docker load -i /tmp/cache/docker.tar
emaydeck-mozilla marked this conversation as resolved.
Show resolved Hide resolved
- run:
name: Tag image
command: |
Expand All @@ -451,7 +456,7 @@ jobs:
# push-image parameters:
# https://circleci.com/developer/orbs/orb/circleci/gcp-gcr#commands-push-image
- gcp-gcr/push-image:
image: $GAR_IMAGE
image: "${GCP_GAR_REPO}/<<parameters.image>>"
google-project-id: GCP_GAR_PROJECT_ID
registry-url: <<parameters.registry-url>>
tag: $GAR_TAG,latest
Expand Down