fix: minor fixes for GAR deploy CircleCI jobs #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaydeck-mozilla
changed the title
taddes
approved these changes
Sep 5, 2024
pjenvey
approved these changes
Sep 5, 2024
pjenvey
pushed a commit
that referenced
this pull request
Sep 5, 2024
This now mounts the workspace so we can load the built image from that. Also, I fixed the image name in the `gcp-gcr/push-image` step. This was tested successfully in https://app.circleci.com/pipelines/github/mozilla-services/autopush-rs/2873/workflows/9adebe2f-13e8-4e5d-a853-e78b7f6ca368
emaydeck-mozilla
added a commit
that referenced
this pull request
Sep 5, 2024
This now mounts the workspace so we can load the built image from that. Also, I fixed the image name in the `gcp-gcr/push-image` step. This was tested successfully in https://app.circleci.com/pipelines/github/mozilla-services/autopush-rs/2873/workflows/9adebe2f-13e8-4e5d-a853-e78b7f6ca368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now mounts the workspace so we can load the built image from that. Also, I fixed the image name in the
gcp-gcr/push-imagestep.This was tested successfully in https://app.circleci.com/pipelines/github/mozilla-services/autopush-rs/2873/workflows/9adebe2f-13e8-4e5d-a853-e78b7f6ca368