Bug/1707 ez vapid #299
Merged
Bug/1707 ez vapid #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would accept invalidly formatted VAPID values (e.g. a string numeric value for `exp`.) With rust, we can no longer do that. Return an error that's more descriptive of what the problem is so that folk can fix it. Closes #1707
Closes: #CONSRV-1708
pjenvey
requested changes
Mar 18, 2022
| @@ -22,22 +23,46 @@ pub fn sentry_middleware( | |||
| scope.add_event_processor(Box::new(move |event| process_event(event, &sentry_request))) | |||
| }); | |||
|
|
|||
| let state = request | |||
There was a problem hiding this comment.
nit: It's probably not hurting anything as is but we might wanna avoid cloning the entire ServerState unless it's necessary. You could just pull out and clone solely the metrics instead.
There was a problem hiding this comment.
I'll admit, I'm being a bit lazy here. .cloned() does a clone if app_data() returns Some. That saves a bit of complexity around dealing with .app_data() returning None for any reason.
| if let Some(api_err) = error.as_error::<ApiError>() { | ||
| if !api_err.kind.is_reportable() { | ||
| debug!("Not reporting error (service error): {:?}", error); | ||
| drop(_scope_guard); |
There was a problem hiding this comment.
I do wonder if both this and the other drop are necessary but fine with leaving it for now 🤷♂️
There was a problem hiding this comment.
Just figuring we should include it in the execute path.
pjenvey
approved these changes
Mar 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covering two issues raised during the canary deploy of autopush-endpoint.
Due to rust's tighter typing requirements, we no longer accept quoted numerics in the VAPID JWT. The returned error would not give developers who are impacted by this change enough insight into what went wrong ("It was working before, what happened?") Added some text to the returned error message body to indicate what the cause of the new rejection is. (#CONSVC-1707 )
Many of the errors being logged to sentry from the new endpoint are not actionable. These are still errors, and require error handling, but do not need to be reported in detail. They can be converted to metrics. Added code to the sentry middleware to reduce the reporting load to sentry (#CONSVC-1708)