-
Notifications
You must be signed in to change notification settings - Fork 710
Record telemetry for nimbus experiments fetching #6972
Record telemetry for nimbus experiments fetching #6972
Conversation
67770a8
to
3698f01
Compare
Request for data collection review formAll questions are mandatory. You must receive a review from a data steward peer on your responses to these questions before shipping new data collection. 1) What questions will you answer with this data? 2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? 3) What alternative methods did you consider to answer these questions? Why were they not sufficient? 4) Can current instrumentation answer these questions? 5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki. Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
6) How long will this data be collected? Choose one of the following: 7) What populations will you measure? 8) If this data collection is default on, what is the opt-out mechanism for users? 9) Please provide a general description of how you will analyze this data. 10) Where do you intend to share the results of your analysis? 12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection? |
3698f01
to
7047ff5
Compare
successful_fetch should be renamed and converted to an event which should contains information about the state(failed or not), but also about the internet connection(if the device is connected to internet or not). |
I think a boolean it's sufficient as long as we report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced of the utility of the successfulFetch
event, so suggest you remove it.
Also: could you amend the data review request to make the data category "Category 1: Technical". Edit: I see you've done the right thing in the metrics.yaml
!
Otherwise, this is nice, well done. Thank you.
…ching Add a timespan to know how much it takes to download the experiments
7047ff5
to
deef6ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having data to set a good default was the principal point, but we also wanted to have an overview idea of how many users could get/fail to fetch based on #6847 requirements. Let's not block this we could do a follow up if it's needed.
Data Review
Yes, through the metrics.yaml file and the Glean Dictionary.
Yes, through the "Send Usage Data" preference in the application settings.
N/A, collection to end in v112
Category 1, Technical data
Default-on
No
Yes
No Resultdata-review+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-review+
For #6847
Add a timespan to know how much it takes to download the experiments
No tests, screenshots, accessibility required
Pull Request checklist
To download an APK when reviewing a PR:
Show All Checks
,Details
next tobuild-focus-debug
orbuild-klar-debug
for changes targeting Klar,View task in Taskcluster
,Artifacts
row,