Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1810553 - Update Focus expiring telemetry #632

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

t-p-white
Copy link
Contributor

@t-p-white t-p-white commented Jan 26, 2023

New values provided by @rtestard in Focus 112_expiry_list doc.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1810553

@github-actions

This comment was marked as resolved.

@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Jan 26, 2023
@t-p-white t-p-white changed the title For 1810553: Updated expiring telemetry For 1810553 - Updated expiring telemetry Jan 26, 2023
@github-actions

This comment was marked as resolved.

@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Jan 26, 2023
@t-p-white t-p-white changed the title For 1810553 - Updated expiring telemetry Bug 1810553 - Updated expiring telemetry Jan 26, 2023
@t-p-white t-p-white changed the title Bug 1810553 - Updated expiring telemetry Bug 1810553 - Update Focus expiring telemetry Jan 26, 2023
@@ -401,12 +401,13 @@ mozilla_products:
data_reviews:
- https://github.com/mozilla-mobile/focus-android/pull/5303
- https://github.com/mozilla-mobile/focus-android/pull/6315
- https://github.com/mozilla-mobile/firefox-android/pull/632
data_sensitivity:
- technical
- interaction
notification_emails:
- [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the product manager's email here for permanent collection. Thanks

@t-p-white
Copy link
Contributor Author

t-p-white commented Jan 26, 2023

Request for Data Collection Renewal

Renew for 6 months

Total: 1
———
nimbus_experiments.nimbus_initial_fetch:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 118
  3. Why was the initial period of collection insufficient?

    • We need this to validate that experiments inclusive of onboarding can fetch the recipe from Nimbus

———

@t-p-white t-p-white added 🕵️‍♀️ needs review PRs that need to be reviewed 🕵️‍♂️ needs data-review PRs that need to be data-reviewed labels Jan 26, 2023
@t-p-white
Copy link
Contributor Author

t-p-white commented Jan 26, 2023

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • This will answer the question if Focus users also have Fenix installed and as a default browser.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This will provide us with info regarding the user base for Focus.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.
 We need a new specific event for a specific app feature.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
Is Fenix the default browser Category 2 - Interaction data mozilla-mobile/focus-android#5295
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • No expiry set.
  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean and Glam.

  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Glam, and with mobile teams.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

@rocketsroger
Copy link
Contributor

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* This will answer the question if Focus users also have Fenix installed and as a default browser.


2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* This will provide us with info regarding the user base for Focus.


3. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* There are no other alternatives.


4. Can current instrumentation answer these questions?


* No.
   We need a new specific event for a specific app feature.


5. List all proposed measurements and indicate the category of data collection for each measurement, using the [Firefox data collection categories](https://wiki.mozilla.org/Data_Collection) found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
Is Fenix the default browser Category 2 - Interaction data mozilla-mobile/focus-android#5295

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* https://dictionary.telemetry.mozilla.org/apps/focus_android


7. How long will this data be collected? Choose one of the following:


* No expiry set.


8. What populations will you measure?


* All channels, all locales, all countries


9. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


10. Please provide a general description of how you will analyze this data.


* Glean and Glam.


11. Where do you intend to share the results of your analysis?


* Only on Glean, Glam, and with mobile teams.


12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No third-party tools.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent, [email protected] will be monitoring the data

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@rocketsroger
Copy link
Contributor

Request for Data Collection Renewal

Renew for 6 months

Total: 1 ——— nimbus_experiments.nimbus_initial_fetch:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Record telemetry for nimbus experiments fetching focus-android#6972](https://github.com/mozilla-mobile/focus-android/pull/6972)

2. When will this collection now expire?
   
   * 118

3. Why was the initial period of collection insufficient?
   
   * We need this to validate that experiments inclusive of onboarding can fetch the recipe from Nimbus

———

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

@rocketsroger rocketsroger removed the 🕵️‍♂️ needs data-review PRs that need to be data-reviewed label Jan 26, 2023
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@rocketsroger rocketsroger added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jan 26, 2023
@t-p-white t-p-white added the 🛬 needs landing PRs that are ready to land label Jan 26, 2023
@mergify mergify bot merged commit 8ff534a into mozilla-mobile:main Jan 26, 2023
@t-p-white t-p-white deleted the 1810553 branch April 27, 2023 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants