Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

For #5295: Add metrics for other Mozilla products. #5303

Merged
merged 3 commits into from
Sep 2, 2021
Merged

For #5295: Add metrics for other Mozilla products. #5303

merged 3 commits into from
Sep 2, 2021

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Sep 1, 2021

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1) What questions will you answer with this data?
This will answer the question if Focus users also have Fenix installed and as a default browser.

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
This will provide us with info regarding the user base for Focus.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?
This is the only way.

4) Can current instrumentation answer these questions?
No. We need a new specific event for a specific app feature.

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
Is Fenix installed Category 2 https://github.com//issues/5295
Is Fenix the default browser Category 2 https://github.com//issues/5295

6) How long will this data be collected? Choose one of the following:
Until 2022-09-01.

7) What populations will you measure?
All release channels and locales.

8) If this data collection is default on, what is the opt-out mechanism for users?
Users can opt of of data collection by disabling Usage and technical data from Settings -> Privacy and security -> Data choices.

9) Please provide a general description of how you will analyze this data.
Glean

10) Where do you intend to share the results of your analysis?
Only on Glean, mobile teams and BD have internal access.

12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
No.

@mcarare mcarare marked this pull request as ready for review September 1, 2021 17:24
@mcarare
Copy link
Contributor Author

mcarare commented Sep 1, 2021

@travis79 Can you also help with this data review? Thank you!

Not sure if the data sensitivity is correct. I chose both:
- technical
- interaction.
These metrics are not something that resulted from direct interaction with the app, so would be technical, but also is a result of a user action. I think in Fenix both are listed also for the list of installed Mozilla products.

@travis79
Copy link
Member

travis79 commented Sep 1, 2021

@travis79 Can you also help with this data review? Thank you!

Not sure if the data sensitivity is correct. I chose both:

  • technical
  • interaction.
    These metrics are not something that resulted from direct interaction with the app, so would be technical, but also is a result of a user action. I think in Fenix both are listed also for the list of installed Mozilla products.

I think both of these are probably "Cat 1, technical data" since they are not measuring the user interaction, but the result of it. Category 2 is still non-sensitive data, so it's better to categorize something as higher rather than lower. I think it should be fine as Cat 2, so reviewing this now.

@travis79
Copy link
Member

travis79 commented Sep 1, 2021

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1) What questions will you answer with this data?
This will answer the question if Focus users also have Fenix installed and as a default browser.

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
This will provide us with info regarding the user base for Focus.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?
This is the only way.

4) Can current instrumentation answer these questions?
No. We need a new specific event for a specific app feature.

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
Is Fenix installed Category 2 https://github.com/[/issues/5295](https://github.com/mozilla-mobile/focus-android/issues/5295)
Is Fenix the default browser Category 2 https://github.com/[/issues/5295](https://github.com/mozilla-mobile/focus-android/issues/5295)

6) How long will this data be collected? Choose one of the following:
Until 2022-09-01.

7) What populations will you measure?
All release channels and locales.

8) If this data collection is default on, what is the opt-out mechanism for users?
Users can opt of of data collection by disabling Usage and technical data from Settings -> Privacy and security -> Data choices.

9) Please provide a general description of how you will analyze this data.
Glean

10) Where do you intend to share the results of your analysis?
Only on Glean, mobile teams and BD have internal access.

12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
No.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary.

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the standard telemetry preference in the app settings.

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection to end in one year: 2022-09-01

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, User interaction or below

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@travis79
Copy link
Member

travis79 commented Sep 1, 2021

As a drive-by suggestion, would you consider adding the needs:data-review tag for this repo, similar to the one Fenix uses? It makes it pretty easy for me to find open data-reviews when I have time to go through them. 🙏

Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the bug as well!

code review r+

@mcarare mcarare added the 🛬 needs landing PRs that are ready to land label Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants