Add notification action for 'Erase + Start from Home View'

[antlam]

From @bbinto (and I'm paraphrasing obvs)

What if we had another notification action that allowed the user to 'Erase' their current browsing session and 'Open' Focus at the same time? Sometimes I want to just fire off a new search with Focus but I'm in another app.

[antlam]

@pocmo how hard would this be?

@mheubusch this is going to be a bit more complicated than 'Open'. Do you have thoughts on this?

[pocmo]

Stop. No new features in 1.1 (I removed the label and added the triage label).

I wonder if this could be something for a shortcut action?

Anyhow: I think that's doable. And after #832 this will be "just" switching to the app and erase. Immediately being able to type a new URL / search will be the default for all.

[bbinto]

Improve notification actions

[pocmo]

@antlam @BBermes Maybe this is also a good thing for adding as a shortcut?

[antlam]

Shortcuts from the Home screen? Would it be something like "Erase" and "Erase and start a new search"? that could work!... 🤔

[bbinto]

@pocmo yes, in addition to the existing shortcut (Erase), we could add the "Erase & start new search". However, would this still make sense though after we do #832?

[mheubusch]

Final reco:
ERASE AND OPEN
OPEN

[mheubusch]

[pocmo]

I'll add the string to the repo (and export) today.

@antlam We also need to decide what icon we want to show in the notification on older devices. The firefox like for open - or the trash can? or something else?

[antlam]

@pocmo is it ok if we dont supply an icon?

[pocmo]

@antlam The API for adding an action to a notification requires supplying an icon. On my Z3C it works if I do not specifiy a valid icon resource id (see screenshot below). However it's not mentioned in the docs that this is supported. So this could be fragile. We would need to test on a variety of devices and (older) Android versions to be sure.

[antlam]

@pocmo can we use the material rubbish bin? the same one on the FAB

[pocmo]

@antlam I just noticed that it suddenly does not fit on the small Z3C (in portrait only) when adding the icon.

[pocmo]

I merged the patch so that we can try it on multiple devices.

Regarding the problem mentioned above, we could:

• Live with it. Only small devices with an older version of Android (that shows the icon) are affected.
• Try to ship without showing an icon (but see concerns above)
• Not ship this feature and update the string in the next version (I am very concerned about the size of the string in other languages now.)
• Something else?

^-- @antlam @bbinto

[antlam]

I'm fine with this as is actually. I'm not too worried about it.

But something like "Reset" or "Restart" might work? I'll let @mheubusch make the call if she wants to change it.

[bbinto]

Definitely not a blocker for this release, and bullet one seems fine for me.

[pocmo]

Alright. I'll close this issue and we can file a new one for one of the upcoming releases if we decide to change something.