Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Add to home screen #833

Closed
9 tasks done
pocmo opened this issue Jun 29, 2017 · 29 comments
Closed
9 tasks done

Add to home screen #833

pocmo opened this issue Jun 29, 2017 · 29 comments

Comments

@pocmo
Copy link
Contributor

pocmo commented Jun 29, 2017

User Story

I want to easily go back to websites I regularly visit in Focus (without ads)

As a Focus user, I want to easily frequent my favorite website so that I don't have to type in the full-length, same, URL each time

Tasks

  • UX design / mocks
  • Implement additional UI (Not part of the first iteration)
  • Add functionality for adding pages to the home screen
  • Get a good icon representing the website
  • Generate a fallback icon
  • Add Telemetry probes
  • Add support for new shortcut API in Android O (Requires SDK 26 -> Build with Android O SDK (Android 8.0 / API 26) #863)
  • Add dialog to update the title of the shortcut
  • Finalize strings
@pocmo
Copy link
Contributor Author

pocmo commented Jul 4, 2017

@brampitoyo @antlam Do you think this should be an additional menu item? Should we just add the icon to the home screen (like Fennec) does or do we need additional UI to let the user modify the name (like Chrome does)?

@pocmo pocmo self-assigned this Jul 5, 2017
@pocmo pocmo changed the title Add to homescreen Add to home screen Jul 5, 2017
@pocmo
Copy link
Contributor Author

pocmo commented Jul 5, 2017

For reference: This is the dialog Chrome shows.

homescreen

@antlam
Copy link
Contributor

antlam commented Jul 5, 2017

For V1, let's keep the additional UI out of it.

We still want some sort of confirmation UI though!

@pocmo
Copy link
Contributor Author

pocmo commented Jul 5, 2017

We still want some sort of confirmation UI though!

I was thinking about using the approach we implemented for the "add to home screen" promotion in Fennec: Switching to the home screen - where the user will see the icon appear.

@pocmo
Copy link
Contributor Author

pocmo commented Jul 5, 2017

For V1, let's keep the additional UI out of it.

I'm okay with that. But note that we have been using the page's title in Fennec and sometime this is not the best title for a launcher icon.

@antlam
Copy link
Contributor

antlam commented Jul 6, 2017

From my meeting with @pocmo:

Messaging this will be important. It might also be an opportunity to try some stuff and figure out what options we have. For example, "save", "download", "install"?

@mheubusch thoughts?

@brampitoyo
Copy link

Adding @antlam because you’ve been meeting with @pocmo about this.

@antlam
Copy link
Contributor

antlam commented Jul 17, 2017

iOS issue: mozilla-mobile/focus-ios#124

Note: language here is still undecided (Save, Add, etc)

Recent user story proposal:

As a Focus user, I want to easily frequent my favorite website so that I don't have to type in the full-length, same, URL each time.

@antlam
Copy link
Contributor

antlam commented Jul 17, 2017

menu - mdpi - saveadd

Essentially what we're talking about ^ (another menu item)

@pocmo if engineering effort isn't too great, a dialog like what you've shown up there actually starts to make a lot of sense because it helps drive home the messaging and also serves as a confirmation step.

@pocmo
Copy link
Contributor Author

pocmo commented Jul 21, 2017

@antlam I landed the first part of this. There's now a menu item and it will add a home screen icon on Android <= 7 (on Android O it doesn't work yet). @ekager is taking this over. For the dialog UI - should we copy what Chrome does or is there anything we should do differently?

@antlam
Copy link
Contributor

antlam commented Jul 24, 2017

@pocmo awesome! I was playing with it over the weekend.

Let's start with the pattern we're seeing in Chrome and then improve from there.

@pocmo pocmo removed their assignment Jul 25, 2017
@bbinto bbinto modified the milestone: Aqua Jul 26, 2017
@pocmo pocmo removed this from the Aqua milestone Jul 26, 2017
@bbinto bbinto modified the milestone: Aqua Jul 26, 2017
@antlam
Copy link
Contributor

antlam commented Jul 27, 2017

Leaving a comment here, we've been polishing and finalizing this UX on Slack. New icon PR incoming.

@mheubusch
Copy link

For the strings,
the label on the menu - Add to Home screen (cap H, lowercase s)
the label for the dialog - Add to Home screen (or Add shortcut to Home screen if there is any reason to think users won't recognize this pattern and need the help)
for the buttons, CANCEL and OK are fine (though ADD might be better)
Do we need a confirmation message? Or is that replaced by the suggestion to switch to Home and show the shortcut?

@antlam
Copy link
Contributor

antlam commented Jul 27, 2017

I don't think we need a confirmation message. The icon shows up on the Home screen and animates in as well.

@pocmo pocmo self-assigned this Jul 28, 2017
@pocmo
Copy link
Contributor Author

pocmo commented Jul 28, 2017

@ekager I added three new strings to the repo and export: dialog_addtohomescreen_title, dialog_addtohomescreen_action_add, dialog_addtohomescreen_action_cancel. We already had one for the menu item: menu_add_to_home_screen. I just updated the text.

@bbinto
Copy link
Contributor

bbinto commented Jul 28, 2017

Definitely too late for this release, but I'd love to see what wording does to the usage of this feature, i.e. if we were to change it. to "Save to Homescreen" or "Bookmark to Homescreen".....thinking "Switchboard" here

@pocmo pocmo removed their assignment Jul 28, 2017
@bbinto bbinto removed the Aqua label Aug 1, 2017
@pocmo pocmo closed this as completed Aug 2, 2017
@nojunpark
Copy link

@pocmo @ekager I was wondering, should the homescreen icon also remember the state of 'Trackers Blocked' switch? (if the user frequents the site that needs TP turned off)

@pocmo
Copy link
Contributor Author

pocmo commented Aug 2, 2017

@npark-mozilla Not a requirement for this version. But you could file a new issue for this. :)

@bbinto
Copy link
Contributor

bbinto commented Aug 3, 2017

Good catch to watch out for in the future.

@Bringoff
Copy link

Bringoff commented Sep 7, 2017

@pocmo I'm investigating Focus code at the moment and thinking about HomeScreen class. It has different implementations for android API < 26 and 26+. Version for Android prior to Nougat operates with deprecated intent directly. But ShortcutManagerCompat support library implementation already exists. Are there any reasons Focus doesn't use this?

@pocmo
Copy link
Contributor Author

pocmo commented Sep 7, 2017

@Bringoff We have a slightly different behavior (On Android < 26 we switch to the home screen after creating the shortcut). But apart from that no there's no reason. We could switch to ShortcutManagerCompat - If you want to do it file an issue and open a PR. :)

@huuhaa
Copy link

huuhaa commented Oct 17, 2017

Suggested as feature request at here:

#1487

This doesn't quite fit under this, but kind of still does. Could there be also possibility to add "quick selection" icon of web page to start screen? It might be just me, but I feel it clumsy to open browser, then if you decide to go at some website you already have at home screen (or folder at heme screen), you have to switch browser to background or close it. Then looking the right shortcut from home screen...

I personally would love an option to add 9 quick selection icons at start screen and maybe side swipe for have 9 more (with dots at bottom to show how many and which page you ar at the moment). What do you think?

@pocmo
Copy link
Contributor Author

pocmo commented Oct 17, 2017

@huuhaa Please file a new issue for that! Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants