-
Notifications
You must be signed in to change notification settings - Fork 710
Add to home screen #833
Comments
@brampitoyo @antlam Do you think this should be an additional menu item? Should we just add the icon to the home screen (like Fennec) does or do we need additional UI to let the user modify the name (like Chrome does)? |
For V1, let's keep the additional UI out of it. We still want some sort of confirmation UI though! |
I was thinking about using the approach we implemented for the "add to home screen" promotion in Fennec: Switching to the home screen - where the user will see the icon appear. |
I'm okay with that. But note that we have been using the page's title in Fennec and sometime this is not the best title for a launcher icon. |
From my meeting with @pocmo: Messaging this will be important. It might also be an opportunity to try some stuff and figure out what options we have. For example, "save", "download", "install"? @mheubusch thoughts? |
iOS issue: mozilla-mobile/focus-ios#124 Note: language here is still undecided (Save, Add, etc) Recent user story proposal:
|
Essentially what we're talking about ^ (another menu item) @pocmo if engineering effort isn't too great, a dialog like what you've shown up there actually starts to make a lot of sense because it helps drive home the messaging and also serves as a confirmation step. |
@pocmo awesome! I was playing with it over the weekend. Let's start with the pattern we're seeing in Chrome and then improve from there. |
Leaving a comment here, we've been polishing and finalizing this UX on Slack. New icon PR incoming. |
For the strings, |
I don't think we need a confirmation message. The icon shows up on the Home screen and animates in as well. |
@ekager I added three new strings to the repo and export: dialog_addtohomescreen_title, dialog_addtohomescreen_action_add, dialog_addtohomescreen_action_cancel. We already had one for the menu item: menu_add_to_home_screen. I just updated the text. |
Definitely too late for this release, but I'd love to see what wording does to the usage of this feature, i.e. if we were to change it. to "Save to Homescreen" or "Bookmark to Homescreen".....thinking "Switchboard" here |
@npark-mozilla Not a requirement for this version. But you could file a new issue for this. :) |
Good catch to watch out for in the future. |
@pocmo I'm investigating Focus code at the moment and thinking about HomeScreen class. It has different implementations for android API < 26 and 26+. Version for Android prior to Nougat operates with deprecated intent directly. But ShortcutManagerCompat support library implementation already exists. Are there any reasons Focus doesn't use this? |
@Bringoff We have a slightly different behavior (On Android < 26 we switch to the home screen after creating the shortcut). But apart from that no there's no reason. We could switch to ShortcutManagerCompat - If you want to do it file an issue and open a PR. :) |
Suggested as feature request at here:
|
@huuhaa Please file a new issue for that! Thank you! |
User Story
Tasks
Implement additional UI(Not part of the first iteration)The text was updated successfully, but these errors were encountered: