Fix #5858 - [XCUITests] Update tests after removing custom search engine icon

[SimonBasca]

Updated tests after #5848 - Remove add search engine button from keyboard #5858

[isabelrios]

Hi @SimonBasca! thanks for this PR! the tests look good but they are not working on iOS 13.3 simulator, at least on my side :( could you please double check?
It is possible to enter the custom search engine name and tap on the url field but then, nothing is written there. I'm investigating that issue...

[isabelrios]

I don't get this typeText working...there is this workaround instead that we could use:

           UIPasteboard.general.string = "https://developer.mozilla.org/search?q=%s"
            
            let tablesQuery = app.tables
            let customengineurlTextView = tablesQuery.textViews["customEngineUrl"]
            customengineurlTextView.staticTexts["URL (Replace Query with %s)"].tap()
            customengineurlTextView.press(forDuration: 1.0)
            app.staticTexts["Paste"].tap()

In this case, the tap on Save button has to be moved to the tests otherwise there was a failure trying to tap there (in the graph we can't add a waitFor, and so the only solution was to add sleep or move the tap on Save button to the test)

[isabelrios]

After this line we would need to add:

waitForExistence(app.buttons["customEngineSaveButton"], timeout: 3)
app.buttons["customEngineSaveButton"].tap()

[isabelrios]

I don't get this typeText working either... Similar solution as above could be:

UIPasteboard.general.string = "window"
app.textFields.firstMatch.press(forDuration: 1)
app.staticTexts["Paste & Go"].tap()

[isabelrios]

As above, but in this case we don't have to go to the url, so only Paste is needed:

UIPasteboard.general.string = "window"
app.textFields.firstMatch.press(forDuration: 1)
app.staticTexts["Paste"].tap()

[isabelrios]

Again, we need to change how to write text in the url bar:

UIPasteboard.general.string = "window"
app.textFields.firstMatch.press(forDuration: 1)
app.staticTexts["Paste"].tap()

[isabelrios]

And here, we need to use the workaround again:

        UIPasteboard.general.string = "http://www.google.com/search?q=&btnI"
        
        let tablesQuery = app.tables
        let customengineurlTextView = tablesQuery.textViews["customEngineUrl"]
        customengineurlTextView.staticTexts["URL (Replace Query with %s)"].tap()
        customengineurlTextView.press(forDuration: 1.0)
        app.staticTexts["Paste"].tap()

[isabelrios]

TypeText not working...using this workaround we get same results:

UIPasteboard.general.string = "window"
app.textFields.firstMatch.press(forDuration: 1)
app.staticTexts["Paste"].tap()

[isabelrios]

As commented on Slack, there are different issues with typeText after the iOS 13.3 update. I have found a few workarounds for those issues. You can find them in the comments and since there are a few, I will commit the changes (not final, still some comments and so in case tests can be improved after you check them) so that we don't loose the how to fix the tests :)

[SimonBasca]

Hi @SimonBasca! thanks for this PR! the tests look good but they are not working on iOS 13.3 simulator, at least on my side :( could you please double check?
It is possible to enter the custom search engine name and tap on the url field but then, nothing is written there. I'm investigating that issue...

I ran the tests several times and in my case, every time the URL was written in the field. I only encountered one intermittent failure for testCustomSearchEngineAsDefault. Several times the the Mozilla search engine was not added as default. With the changes I did it should be working fine now.

[isabelrios]

Changes addressed and everything looking good + all tests green!