Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a PR Template #5928

Closed
obitodarky opened this issue Dec 18, 2019 · 1 comment
Closed

Have a PR Template #5928

obitodarky opened this issue Dec 18, 2019 · 1 comment

Comments

@obitodarky
Copy link
Contributor

This repository does not seem to have a PR template. Most of the good repositories follow a PR template to make it easier for contributors and maintainers to publish and view Pull Requests.
I would suggest a good PR template be created for this repository. Preferably ones that suggest contributors add screenshots for UI changes if possible and describe their changes in detail.
@obitodarky
Copy link
Contributor Author

I just found out that it already exists at https://github.com/mozilla-mobile/firefox-ios/blob/master/PULL_REQUEST_TEMPLATE.

Closing this for now, but I would suggest it be in the .github/ directory.

dnarcese added a commit to dnarcese/firefox-ios that referenced this issue Dec 20, 2019
@dnarcese
Fix mozilla-mobile#5928: Land strings for v22 cover sheet
17b3e54
dnarcese added a commit that referenced this issue Dec 20, 2019
@dnarcese
Fix #5928: Land strings for v22 cover sheet (#5943)
9ab1a2c
garvankeeley added a commit that referenced this issue Jan 1, 2020
@robomex @dnarcese
@garvankeeley @nbhasin2 @isabelrios @dfperry5 @yusadogru @KrystynaKruchkovska @obitodarky @SimonBasca @maleshchenko
WebXR: Remove camera view when moving to non-XR site, pause session u…
97f66e8 
…pon reload/URL traversal, hook up onStartLoad (#5970)

* Fix #5848: Remove add search engine button from keyboard (#5857)

* Fix #5868 update onepassword in carthage (#5870)

* change source of onepassword-app-extension and update

* Update Cartfile

* Update Cartfile.resolved

* Fix: Expression implicitly coerced from '[String : Any?]' to '[String : Any]' (#5876)

* Add Fragment Support for Search Terms  (#5847)

* add fragment support for search engine

* refactor and re indent file

* add test case of fragment usage for search term

* Revert "Fix #5868 update onepassword in carthage (#5870)" (#5883)

This reverts commit 13c3398.

* Fix #5877 [iPad][iOS 12.x] Library panel buttons are cut off

* Organize LibraryViewController into separate files

* Fix #5868: update 1pw in cartfile (#5884)

* Fix UIView.isHidden must be used from main thread only (#5875)

* Fix UIView.isHidden must be used from main thread only

* Revert "Fix UIView.isHidden must be used from main thread only"

This reverts commit e5ce847.

* FirefoxAccountStateChange post notification wrapped to notify on the main thread.

* Fix #5877 - [iPad][iOS 12.x] Library panel buttons are cut off (#5886)

* Fix #5826 - XCUITests fail to type in URL bar (#5831)

* Fix #5826 - XCUITests fail to type in URL bar

* waitfor textfield url before typing

* change url for address

* try tapping on address textField first

* new fixes

* using firstMatch instead of address or url

* trying to find  workaround

* more fixes

* wait longer for webview to be loaded

* comment workaround

* fix waiting for fxaccount website

* removing sleep

* Fix: Expression implicitly coerced from '[String : Any?]' to '[String : Any]' (#5876)

* Add Fragment Support for Search Terms  (#5847)

* add fragment support for search engine

* refactor and re indent file

* add test case of fragment usage for search term

* Revert "Fix #5868 update onepassword in carthage (#5870)" (#5883)

This reverts commit 13c3398.

* Fix #5868: update 1pw in cartfile (#5884)

* Fix UIView.isHidden must be used from main thread only (#5875)

* Fix UIView.isHidden must be used from main thread only

* Revert "Fix UIView.isHidden must be used from main thread only"

This reverts commit e5ce847.

* FirefoxAccountStateChange post notification wrapped to notify on the main thread.

* Fix #5826 - XCUITests fail to type in URL bar (#5831)

* Fix #5826 - XCUITests fail to type in URL bar

* waitfor textfield url before typing

* change url for address

* try tapping on address textField first

* new fixes

* using firstMatch instead of address or url

* trying to find  workaround

* more fixes

* wait longer for webview to be loaded

* comment workaround

* fix waiting for fxaccount website

* removing sleep

* Fix #5823 (#5861)

Firefox loses URL when opening a link in a new tab without internet connection #5823

* Fix #5508 Add Unit tests for Everything and Today and Yesterday options for Clear Recent History, as well as test to validate that all expected options are shown for Clear Recent History (#5899)

* Fix #5679 - Added ability for user remove an account if they are unable to verify email (#5897)

- Added account removal alert

- Moved UserDefaults Prefs helper to Shared so that we can easily write Profile / Account unit tests

- Added a MockAccount class to mock the Firefox account for testing purposes

* Fix #5904: UIView.isHidden must be used from main thread (#5906)

* Fix #5866 if the webpage has low-res favicon, show default icon

Changed to favicon to be displayed size minimum of 32x32 in TopSites

* Fix #5862 - Reading list text is not fully displayed in landscapeMode (#5872)

* Fix #5902 - XCUITests more iOS13 fixes (#5903)

* Fix #5902 - XCUITests more iOS13 fixes

* adding sleep

* remove sleep and increase timeout

* fix smoketest

* Fix #5869 - The  button from the toast notification is too small (#5895)

* Fix #5869 - The  button from the toast notification is too small

* ButtonToast size change

* Fix #5888 - QR code frame is not aligned (#5922)

* Fix #5915 - Doesn't build on latest Xcode (#5932)

- Updated application-services to v0.47.0

* Issue #5753: Separated contributing from readme (#5929)

* seperated contributing from readme

* Removed upercase in "CONTRIBUTING"

* Fix #5781 - [iPad] Tabs tray layout is not correct when entering split screen (#5925)

* Bug 1604804: blob download (#5935)

* Fix #5559 - use special fingerprinting list / refactor python code to swift (#5936)

* Port content blocker python code to swift

* remove python file

* Change build scripts

* add license header

* Fix #5928: Land strings for v22 cover sheet (#5943)

* NoIssue-TryingToFixXcode11.3TestsFailures (#5939)

* NoIssue-TryingToFixXcode11.3TestsFailures

* disable sync and translation tests

* new fixes for navigation, private browsing and tp

* fix for dataManagement, domain autocomplete, homepagesettings

* fix dataManagement, navigation and sync ui tests

* Remove camera view when moving to non-XR site

* Wired up "Stop AR" menu button with new web method

* “Fix (#5948)

using workaround to fix typeText issues

forgot tap and check

fix delete custom search engine

Cleanup

* Move applicationName as FxiOS to property (#5955)

* Fix #5237 - 'Recent Bookmarks' header should match other table view headers (#5960)

* Remove obsolete usingMetal, useMetalForARKey

* Pause ARSession upon reload/URL traversal

* Run onStartLoad when didStartProvisionalNavigation

* Removed xrStopAR tabAction

Co-authored-by: Mustafa Hastürk <[email protected]>
Co-authored-by: Daniela Arcese <[email protected]>
Co-authored-by: Garvan Keeley <[email protected]>
Co-authored-by: Nishant Bhasin <[email protected]>
Co-authored-by: isabelrios <[email protected]>
Co-authored-by: dfperry5 <[email protected]>
Co-authored-by: Yuşa Doğru <[email protected]>
Co-authored-by: KrystynaKruchkovska <[email protected]>
Co-authored-by: Harsh Mehta <[email protected]>
Co-authored-by: SimonBasca <[email protected]>
Co-authored-by: Mykola Aleshchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@obitodarky