Bug 1417864 - Don't use the URL keyboard in custom search title

[alyssais]

Previously, CustomSearchEngineTextView set the keyboard type of every text view it created to .URL, which prevented spaces being entered using the keyboard.

This commit changes that text field so that it uses the standard keyboard, but with word-based autocapitalization so custom search titles are title-cased.

Pull Request Checklist

• My patch has gone through review and I have addressed review comments

• My patch has a standard commit message that looks like Bug 12345678 - This fixes something something

• I have updated the Unit Tests to cover new or changed functionality

• I have updated the UI Tests to cover new or changed functionality

• I have marked the bug with [needsuplift]

• I have made sure that localizable strings use NSLocalizableString()

[justindarc]

Thanks for the patch! With your patch right now, I believe titleField technically still is a UIKeyboardType.URL. It might be better to just change CustomSearchEngineTextView.init to add an additional argument keyboardType: UIKeyboardType = .default so you can just specify the keyboardType: .URL argument when initializing urlField. Does that make sense? You can even specify autocapitalizationType = .words for the textField in the initializer as long as it is being created with a keyboardType of .default. Let me know if you have any other questions. I can help get your patch landed once you've made these changes :-)

[alyssais]

With your patch right now, I believe titleField technically still is a UIKeyboardType.URL.

Don't think so?

(lldb) p titleField.textField.keyboardType
(UIKeyboardType) $R0 = default

Still want me to make those changes? I'm not sure it makes sense to automatically set autocapitalizationType based on keyboardType because nothing about a CustomSearchEngineTextView being the default keyboard type implies that words should necessarily be capitalized, as far as I can see…

[justindarc]

Oh, right because you removed textField.keyboardType = .URL, so .URL is no longer the default value. I still think the changes I requested would make this code easier to follow. CustomSearchEngineTextView is not used anywhere else in the app except for these two text inputs, so it makes more sense to me to allow the resulting text input to be completely configurable from the init() directly as opposed to having to reach in to the CustomSearchEngineTextView after initialization and overriding its configuration.

[alyssais]

Okay, I'll have a look at making that happen.

[alyssais]

@justindarc how does that look? Sorry for the delay!

[alyssais]

Wasn't sure if there's a better way to do this. I couldn't find one.

[alyssais]

Why was this closed? The bug is still open. Has it been fixed in another way?