-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Search Engine screen’s Title box uses the URL keyboard #5190
Comments
@farhanpatel @SimonBasca -- Is this still an issue? Something I could take on? Not too experienced with open source, though i did just open a PR with some unit tests :) |
@dfperry5 This issue is still reproducible on Firefox 21.0 (16918). This is free to take if you're willing to help. If you have any questions or need guidance, you can contact @garvankeeley. |
@SimonBasca - I'm gonna start working on this today! @garvankeeley - sorry in advance if i ask too many questions! I took a shot at it with this commit - let me know if theres something I need to change / address :) |
…ox to use the default keyboard
@garvankeeley -- any feedback on the above commit, before I open a PR? :) |
PR looks good so far |
@garvankeeley - PR opened here: #5927 |
Verified as fixed on master c2574a0. |
Logged via: https://bugzilla.mozilla.org/show_bug.cgi?id=1417864
Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 11_0_3 like Mac OS X) AppleWebKit/604.1.38 (KHTML, like Gecko) FxiOS/10.1b7709 Mobile/15A432 Safari/604.1.38
Steps to reproduce:
Actual results:
The URL keyboard is displayed, which does not allow spaces to be entered
Expected results:
The standard keyboard (with capitalisation probably) should have been displayed to allow spaces to be entered.
The text was updated successfully, but these errors were encountered: