Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Search Engine screen’s Title box uses the URL keyboard #5190

Closed
SimonBasca opened this issue Jun 27, 2019 · 8 comments
Closed

Add Search Engine screen’s Title box uses the URL keyboard #5190

SimonBasca opened this issue Jun 27, 2019 · 8 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected P3 Issues that would be nice to have for the current release QA Verified Issue verified by QA
Milestone
v22

Comments

@SimonBasca
Copy link
Contributor

Logged via: https://bugzilla.mozilla.org/show_bug.cgi?id=1417864

Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 11_0_3 like Mac OS X) AppleWebKit/604.1.38 (KHTML, like Gecko) FxiOS/10.1b7709 Mobile/15A432 Safari/604.1.38

Steps to reproduce:

  1. Go to Settings
  2. Select “Search”
  3. Select “Add Search Engine”
  4. Focus the “Title” field

Actual results:

The URL keyboard is displayed, which does not allow spaces to be entered

Expected results:

The standard keyboard (with capitalisation probably) should have been displayed to allow spaces to be entered.
@SimonBasca SimonBasca added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Jun 27, 2019
@SimonBasca
Copy link
Contributor Author

#3466

@farhanpatel farhanpatel added the P3 Issues that would be nice to have for the current release label Jul 9, 2019
@dfperry5
Copy link
Contributor

@farhanpatel @SimonBasca -- Is this still an issue? Something I could take on? Not too experienced with open source, though i did just open a PR with some unit tests :)

@SimonBasca
Copy link
Contributor Author

@dfperry5 This issue is still reproducible on Firefox 21.0 (16918). This is free to take if you're willing to help. If you have any questions or need guidance, you can contact @garvankeeley.

@dfperry5
Copy link
Contributor

dfperry5 commented Dec 16, 2019 •
edited
Loading

@SimonBasca - I'm gonna start working on this today!

@garvankeeley - sorry in advance if i ask too many questions!

I took a shot at it with this commit - let me know if theres something I need to change / address :)

dfperry5 added a commit to dfperry5/firefox-ios that referenced this issue Dec 16, 2019
@dfperry5
Fix mozilla-mobile#5190 - updating Add Search Engine screen's title b…
acd2fec 
…ox to use the default keyboard
@dfperry5
Copy link
Contributor

@garvankeeley -- any feedback on the above commit, before I open a PR? :)

@garvankeeley
Copy link
Contributor

PR looks good so far

@dfperry5
Copy link
Contributor

@garvankeeley - PR opened here: #5927

@athomasmoz athomasmoz added this to the v22 milestone Jan 10, 2020
@csuciu
Copy link

csuciu commented Jan 13, 2020

Verified as fixed on master c2574a0.

@csuciu csuciu added the QA Verified Issue verified by QA label Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected P3 Issues that would be nice to have for the current release QA Verified Issue verified by QA
Projects
None yet
Milestone
v22
Development

No branches or pull requests
6 participants
@farhanpatel @csuciu @garvankeeley @dfperry5 @SimonBasca @athomasmoz