Share to more stuff #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmarceau
pushed a commit
that referenced
this pull request
Apr 1, 2022
…#9496) * Remove white border from FirefoxHomeHighlightCell * Remove Snapkit calls from NoLoginsView.swift * Remove SnapKit from LoginListTableViewCell * Remove SnapKit from LibraryShortcutView * Remove SnapKit from LoginDetailViewController and SensitiveViewController - fix typo in LoginDetailTableViewCellDelegate, canPerform - remove unnecessary uses of self * Remove Snapkit from AddCredentialViewController - remove unused wrapFooter method * Remove Snapkit from LoginDetailTableViewCell - remove unused imports from LibraryShortcutView and SensitiveViewController * MR feedback * MR feedback #2 * MR feedback #3 Co-authored-by: Michael Pace <[email protected]>
Closed
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
6 tasks
cyndichin
added a commit
that referenced
this pull request
Oct 10, 2024
# This is the 1st commit message: fix conflicts # This is the commit message #2: update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bustage is just from a bad number in the Table view controller. I also abstracted a bit.
1.) there is no reason for us to hold a reference to a SLComposeSheetConfigurationItem
2.) I changed how the config items appear so that they now use the standard title-value setup. i.e. they say:
[Share To: Bookmarks]
3.) This now looks at what you chose so that we use the correct ShareHandler when you hit Post