Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #28498: Fixed empty list text alignment in Tabs tray, history and downloads #28525

Closed
wants to merge 2 commits into from

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Jan 13, 2023

The PR fixes the text alignment of empty tabs tray, history and downloads messages.

Steps to reproduce

  1. Open the tabs tray
  2. Check empty tabs tray message
  3. Tap the private open tabs
  4. Check empty private tabs tray message
  5. Open "History" from the home screen ⋮ button
  6. Check empty history list message
  7. Open "Downloads" from the home screen ⋮ button
  8. Check empty Downloads list message

Issue video

https://www.loom.com/share/ec33cb283a324f60a78b6da4441172b4

Demo video after fix

https://www.loom.com/share/04a3b526e7ad440f8efa01d76da029e5

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #28498

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@gitstart gitstart marked this pull request as ready for review January 13, 2023 09:31
@gitstart gitstart requested review from a team as code owners January 13, 2023 09:31
@Mugurell
Copy link
Contributor

Thank you for working on this!
Before merging can you please squash the commits and rename the resulting commit and PR to follow our recommended structure from https://github.com/mozilla-mobile/shared-docs/blob/main/android/CONTRIBUTING_code.md#creating-a-pull-request (eg: For #28498: Fix text alignment in ...)?

@gitstart
Copy link
Contributor Author

Thank you for working on this! Before merging can you please squash the commits and rename the resulting commit and PR to follow our recommended structure from https://github.com/mozilla-mobile/shared-docs/blob/main/android/CONTRIBUTING_code.md#creating-a-pull-request (eg: For #28498: Fix text alignment in ...)?

Thank you for reviewing the PR @Mugurell,
Requested changes are done. Please check..

@gitstart gitstart changed the title [Bug]: Misplaced empty tabs tray, history and downloads messages #28498 For #28498: Fixed empty list text alignment in Tabs tray, history and downloads Jan 17, 2023
@Mugurell Mugurell mentioned this pull request Jan 17, 2023
4 tasks
Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you for being quick to help with this!

@jonalmeida
Copy link
Contributor

jonalmeida commented Jan 17, 2023

Thanks for fixing this! @mavduevskiy and I have just reverted the change that introduced this bug. So we should hold off on landing this fix.

@gitstart
Copy link
Contributor Author

Looks good! Thank you for being quick to help with this!

Thank you @Mugurell for reviewing the PR and approving it

@gitstart
Copy link
Contributor Author

Thanks for fixing this! @mavduevskiy and I have just reverted the change that introduced this bug. So we should hold off on landing this fix.

Thank you @jonalmeida hope the PR get merged soon..

@jonalmeida
Copy link
Contributor

Thank you jonalmeida hope the PR get merged soon..

It was merged! Hopefully, you see the new update soon in the next nightly build.

@Mugurell
Copy link
Contributor

Closing this PR as not needed anymore.
Thank you @gitstart!

@Mugurell Mugurell closed this Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Misplaced empty tabs tray, history and downloads messages
3 participants