Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][RTL] Potentially don't set automatic direction based on the text directionality, for text across the UI #7861

Closed
fluffyemily opened this issue Jan 22, 2020 · 11 comments · Fixed by #28340, Leland-Takamine/fenix#160, C-EO/fenix#4 or fork-house/fenix#14
Closed

[Bug][RTL] Potentially don't set automatic direction based on the text directionality, for text across the UI #7861

fluffyemily opened this issue Jan 22, 2020 · 11 comments · Fixed by #28340, Leland-Takamine/fenix#160, C-EO/fenix#4 or fork-house/fenix#14
Assignees
@mavduevskiy
Labels
🐞 bug Crashes, Something isn't working, .. 🌐 L10N:RTL
Milestone
110

Comments

@fluffyemily
Copy link

fluffyemily commented Jan 22, 2020 •
edited by data-sync-user
Loading

Original bug filed under GeckoView by @itiel. Screenshots attached to original bug to demonstrate.

Currently, (almost) everywhere in the UI the alignment of varios text elements is decided based of the text directionality.
This usually makes sense, but this an issue where English text actually should appear.
See the attached screenshots with examples for this.

While it's possible to address each text element separately, I don't see any reason (well, from RTL POV anyway) not to make the text align to the left for LTR, and to the right for RTL.

┆Issue is synchronized with this Jira Task
@fluffyemily fluffyemily added the 🐞 bug Crashes, Something isn't working, .. label Jan 22, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 22, 2020
@boek boek removed needs:group-triage needs:triage Issue needs triage labels Feb 18, 2020
@ItielMaN ItielMaN mentioned this issue Jun 6, 2020
Closed
@stale
Copy link

stale bot commented Feb 5, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 5, 2021
@stale stale bot closed this as completed Feb 12, 2021
@ItielMaN ItielMaN mentioned this issue Apr 18, 2022
Closed
@Delphine
Copy link
Contributor

Seems like this is still an issue, and that if/when fixed, could potentially fix other right-to-left issues in Fenix (as per this comment).
@amedyne Not sure you are the right person to flag for this, but this currently affects all 4 of our right-to-left locales (Hebrew, Arabic, Urdu and Persian).

@Delphine Delphine reopened this Apr 21, 2022
@stale stale bot removed the wontfix label Apr 21, 2022
@stale
Copy link

stale bot commented Nov 19, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 19, 2022
@ItielMaN
Copy link

Still an issue.

@stale stale bot removed the wontfix label Nov 19, 2022
@Delphine Delphine mentioned this issue Nov 21, 2022
Closed
@Delphine
Copy link
Contributor

Hi @cpeterso, there seems to be growing interest in launching more broadly right-to-left locales on Firefox for Android, and this is still a major issue that has been going on for almost 3 years.
Currently there are still some other RTL issues - but fixing this one may also just fix the rest.
Could you help get this one prioritized? thanks

@cpeterso
Copy link

Currently there are still some other RTL issues - but fixing this one may also just fix the rest.
Could you help get this one prioritized? thanks

I talked to Android PM and we moved this bug near the top of our Android backlog. I don't have an ETA, though.

@mavduevskiy mavduevskiy self-assigned this Dec 29, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Dec 29, 2022
Closes mozilla-mobile#7861: position text based on layout direction, …
7114f47 
…but text directionality
@mavduevskiy mavduevskiy mentioned this issue Dec 29, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Dec 29, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Dec 29, 2022
Closes mozilla-mobile#7861: position text based on layout direction, …
0bc3a38 
…not text directionality
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Dec 29, 2022
Closes mozilla-mobile#7861: position text based on layout direction, …
212f456 
…not text directionality
@mergify mergify bot closed this as completed in #28340 Jan 10, 2023
mergify bot pushed a commit that referenced this issue Jan 10, 2023
@mergify
Closes #7861: position text based on layout direction, not text direc…
48163ef 
…tionality
@github-actions github-actions bot mentioned this issue Jan 10, 2023
Merged
@github-actions github-actions bot reopened this Jan 10, 2023
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Jan 10, 2023
@github-actions github-actions bot added this to the 110 milestone Jan 10, 2023
@delia-pop
Copy link

Verified as fixed on the latest Nightly 110.0a1 from 01/16 with Google Pixel 6 (Android 13), Xiaomi 12 Pro (Android 13) and Lenovo Yoga Tab 11 (Android 11).
The URLs and other UI elements are correctly aligned to the right when RTL language is used.
Please note that the following issues were observed while testing: #28550 , #28498, #26728, #28342.

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 16, 2023
@mavduevskiy
Copy link
Contributor

@delia-pop
Does it mean those issues were solved and can be closed or do we still need to work on those?

mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jan 17, 2023
Revert "Closes mozilla-mobile#7861: position text based on layout dir…
841412d 
…ection, not text directionality"

This reverts commit 48163ef.
@mavduevskiy mavduevskiy reopened this Jan 17, 2023
@mavduevskiy
Copy link
Contributor

Reverted the fix due to a regression.

@jonalmeida
Copy link
Contributor

jonalmeida commented Jan 17, 2023 •
edited
Loading

@mavduevskiy and I spoke offline, and when we land this fix again. We can test to make sure that it doesn't cause the same regression again.

#28525 is a contributor fix that was trying to do this, so we could consider if this is the right patch to apply when re-landing.

@mergify mergify bot closed this as completed in 9b6d926 Jan 17, 2023
mergify bot pushed a commit that referenced this issue Jan 17, 2023
@mergify
Revert "Closes #7861: position text based on layout direction, not te…
36846ac 
…xt directionality"

This reverts commit 48163ef.

(cherry picked from commit 9b6d926)
mergify bot pushed a commit that referenced this issue Jan 18, 2023
@mergify
Revert "Closes #7861: position text based on layout direction, not te…
91e85ed 
…xt directionality"

This reverts commit 48163ef.

(cherry picked from commit 9b6d926)
JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this issue Jan 25, 2023
@mergify
[fenix] Revert "Closes mozilla-mobile/fenix#7861: position text based…
07cdeea 
… on layout direction, not text directionality"

This reverts commit 2f2d3dc.
@mavduevskiy mavduevskiy reopened this Feb 2, 2023
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Feb 2, 2023
Closes mozilla-mobile#7861: position text based on layout direction, …
9ab1d66 
…not text directionality
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Feb 2, 2023
@github-actions github-actions bot mentioned this issue Feb 2, 2023
Closed
4 tasks
@mavduevskiy mavduevskiy removed the eng:qa:verified QA Verified label Feb 2, 2023
@github-actions github-actions bot mentioned this issue Feb 6, 2023
Merged
@gabrielluong gabrielluong removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Feb 8, 2023
@gabrielluong
Copy link
Member

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1815637

Change performed by the Move to Bugzilla add-on.

@github-actions github-actions bot mentioned this issue Feb 9, 2023
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 16, 2023
@mergify
[fenix] Revert "Closes mozilla-mobile/fenix#7861: position text based…
96f8421 
… on layout direction, not text directionality"

This reverts commit 2f2d3dc.

(cherry picked from commit 9b6d926)
akliuxingyuan pushed a commit to akliuxingyuan/iceraven-browser that referenced this issue Mar 15, 2023
@mergify
[fenix] Revert "Closes mozilla-mobile#7861: position text based on la…
7a47016 
…yout direction, not text directionality"

This reverts commit 2f2d3dc.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mavduevskiy mavduevskiy

Labels
🐞 bug Crashes, Something isn't working, .. 🌐 L10N:RTL
Projects
None yet
Milestone
110
10 participants
@kbrosnan @Delphine @cpeterso @gabrielluong @boek @jonalmeida @fluffyemily @ItielMaN @delia-pop @mavduevskiy