This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
for #24931: create address label and description based on available data #25039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
MozillaNoah
reviewed
May 2, 2022
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
app/src/test/java/org/mozilla/fenix/settings/address/ext/AddressKtTest.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
app/src/test/java/org/mozilla/fenix/settings/address/ext/AddressKtTest.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
app/src/test/java/org/mozilla/fenix/settings/address/ext/AddressKtTest.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
gabrielluong
reviewed
May 2, 2022
MatthewTighe
force-pushed
the
address-labels
branch
from
b9203d6 to
7ae2b16
Compare
|
It sounds like we're close to alignment on the field overrides, names, and the aspects of the address which should be included in the label and description, so I think this could be ready for another review pass. |
gabrielluong
suggested changes
May 4, 2022
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
MatthewTighe
force-pushed
the
address-labels
branch
from
f01d34b to
116b22c
Compare
|
Needed to add some handling for longer descriptions in our text items, since the combination of fields can really easily reach the max size. This is on a larger, almost tablet-sized device for reference: |
MatthewTighe
force-pushed
the
address-labels
branch
4 times, most recently
from
549fa99 to
fea868d
Compare
gabrielluong
suggested changes
May 6, 2022
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/address/ext/Address.kt
Outdated
Show resolved
Hide resolved
MatthewTighe
force-pushed
the
address-labels
branch
from
fea868d to
9087b72
Compare
gabrielluong
approved these changes
May 10, 2022
…on available data
MatthewTighe
force-pushed
the
address-labels
branch
from
9087b72 to
684f145
Compare
MatthewTighe
added
the
pr:needs-landing
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24931
Desktop code is here
To download an APK when reviewing a PR: