Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Display the proper label and description for an Address item #24931

Closed
gabrielluong opened this issue Apr 22, 2022 · 3 comments · Fixed by #25039
Closed

Display the proper label and description for an Address item #24931

gabrielluong opened this issue Apr 22, 2022 · 3 comments · Fixed by #25039
Assignees
@MatthewTighe
Labels
eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Milestone
102

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Apr 22, 2022 •
edited by data-sync-user
Loading

I will file a follow to display the proper label and description. I think we will want to investigate how Desktop formats this.

Originally posted by @gabrielluong in #24928 (comment)

We want to investigate how Desktop formats their Name and Address description and ensure we are following the same format in our address list.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong mentioned this issue Apr 22, 2022
Merged
3 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 22, 2022
@gabrielluong gabrielluong added Feature:Autofill Address and Credit Card autofill and removed needs:triage Issue needs triage labels Apr 22, 2022
@gabrielluong
Copy link
Member Author

Please also link to the Desktop code that does the formatting.

@MatthewTighe MatthewTighe self-assigned this Apr 28, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Apr 29, 2022
@MatthewTighe
for mozilla-mobile#24931: create address label and description based …
045d03b 
…on available data
@MatthewTighe MatthewTighe mentioned this issue Apr 29, 2022
Merged
@MatthewTighe
Copy link
Contributor

Core of the desktop code can be found here

MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue May 6, 2022
@MatthewTighe
for mozilla-mobile#24931: create address label and description based …
9087b72 
…on available data
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue May 10, 2022
@MatthewTighe
for mozilla-mobile#24931: create address label and description based …
684f145 
…on available data
mergify bot pushed a commit that referenced this issue May 10, 2022
@MatthewTighe @mergify
for #24931: create address label and description based on available data
483f5a9
@gabrielluong gabrielluong added this to the 102 milestone May 11, 2022
@delia-pop
Copy link

Verified as fixed on Nightly 102 from 05/25.

@delia-pop delia-pop added the eng:qa:verified QA Verified label May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MatthewTighe MatthewTighe

Labels
eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
None yet
Milestone
102
Development

Successfully merging a pull request may close this issue.

for #24931: create address label and description based on available data MatthewTighe/fenix
3 participants
@gabrielluong @MatthewTighe @delia-pop