Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #23970, #23969, #23968 - Convert home screen headers to compose #24464

Merged
merged 4 commits into from
Mar 29, 2022
Merged

For #23970, #23969, #23968 - Convert home screen headers to compose #24464

merged 4 commits into from
Mar 29, 2022

Conversation

sarah541
Copy link
Contributor

Fixes #23970
Fixes #23969
Fixes #23968

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sarah541 sarah541 requested a review from gabrielluong March 25, 2022 18:28
@sarah541 sarah541 requested review from a team as code owners March 25, 2022 18:28
@gabrielluong gabrielluong changed the title Hompage to compose For #23970, #23969, #23968 - Convert home screen headers to compose Mar 25, 2022
@gabrielluong
Copy link
Member

Let's wait until Monday to land this. Thanks!

@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2022

This pull request has conflicts when rebasing. Could you fix it @sarah541? 🙏

@sarah541 sarah541 force-pushed the hompage_to_compose branch 3 times, most recently from b47ed57 to 02e3275 Compare March 28, 2022 17:06
@sarah541 sarah541 force-pushed the hompage_to_compose branch from 02e3275 to f3e87ad Compare March 28, 2022 21:27
@sarah541 sarah541 force-pushed the hompage_to_compose branch from f3e87ad to aefbb79 Compare March 28, 2022 22:03
@gabrielluong gabrielluong dismissed MozillaNoah’s stale review March 28, 2022 23:03

This looks like it is all resolved.

@sarah541 sarah541 added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Mar 28, 2022
@mergify mergify bot merged commit 3b39b46 into mozilla-mobile:main Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabrielluong gabrielluong gabrielluong approved these changes

@MozillaNoah MozillaNoah MozillaNoah left review comments

Assignees

@gabrielluong gabrielluong

Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
3 participants
@sarah541 @gabrielluong @MozillaNoah