Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Migrate RecentBookmarksHeaderViewHolder to Compose #23969

Closed
Mugurell opened this issue Feb 24, 2022 · 0 comments · Fixed by #24464
Closed

Migrate RecentBookmarksHeaderViewHolder to Compose #23969

Mugurell opened this issue Feb 24, 2022 · 0 comments · Fixed by #24464
Assignees
@sarah541
Labels
compose Tickets involving Composable changes eng:health Improve code health Feature:HomeScreen
Milestone
100

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Feb 24, 2022 •
edited by data-sync-user
Loading

Breakage of #22755

Refers to just the RecentBookmarksHeaderViewHolder which adds a "Recent bookmarks" header.
RecentBookmarksViewHolder which shows the recent bookmarks is already based on the compose framework.

The compose version can be added to the current RecyclerView but before doing so we should ensure there will be no performance regression introduced.
To profile the differences the steps from #21854 (comment) can be used.

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 24, 2022
@kbrosnan kbrosnan added eng:health Improve code health and removed needs:triage Issue needs triage labels Feb 24, 2022
@gabrielluong gabrielluong added this to the 100 milestone Mar 10, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 14, 2022
@sarah541
For mozilla-mobile#23969 - migrate homescreen recent bookmarks to com…
4877659 
…pose
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 14, 2022
@sarah541
For mozilla-mobile#23969 - migrate homescreen recent bookmarks to com…
10e2916 
…pose

For mozilla-mobile#23969 - migrate homescreen recent bookmarks to compose
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 14, 2022
@sarah541
For mozilla-mobile#23969 - migrate homescreen recent bookmarks to com…
ef8760f 
…pose

For mozilla-mobile#23969 - migrate homescreen recent bookmarks to compose
@sarah541 sarah541 mentioned this issue Mar 16, 2022
Closed
3 tasks
@gabrielluong gabrielluong changed the title Migrate homescreen recent bookmarks to Compose Migrate RecentBookmarksHeaderViewHolder to Compose Mar 18, 2022
@gabrielluong gabrielluong added the compose Tickets involving Composable changes label Mar 18, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 21, 2022
@sarah541
For mozilla-mobile#23969 - migrate homescreen recent bookmarks to com…
1c3ba97 
…pose
@sarah541 sarah541 mentioned this issue Mar 21, 2022
Closed
3 tasks
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 23, 2022
@sarah541
For mozilla-mobile#23969 - migrate homescreen recent bookmarks to com…
afbf06f 
…pose
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 23, 2022
@sarah541
For mozilla-mobile#23969 - migrate homescreen recent bookmarks to com…
94e8d95 
…pose
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 24, 2022
@sarah541
For mozilla-mobile#23969 - migrate homescreen recent bookmarks to com…
996b8b8 
…pose
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 25, 2022
@sarah541
For mozilla-mobile#23969 - Migrate homescreen recent bookmarks to com…
7b80b0c 
…pose
@sarah541 sarah541 mentioned this issue Mar 25, 2022
Merged
3 tasks
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 28, 2022
@sarah541
For mozilla-mobile#23969 - Migrate homescreen recent bookmarks to com…
6ab8757 
…pose
sarah541 added a commit to sarah541/fenix that referenced this issue Mar 28, 2022
@sarah541
For mozilla-mobile#23969 - Migrate homescreen recent bookmarks to com…
225ca9f 
…pose
@mergify mergify bot closed this as completed in #24464 Mar 29, 2022
mergify bot pushed a commit that referenced this issue Mar 29, 2022
@sarah541 @mergify
For #23969 - Migrate homescreen recent bookmarks to compose
ce7d2d1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarah541 sarah541

Labels
compose Tickets involving Composable changes eng:health Improve code health Feature:HomeScreen
Projects
None yet
Milestone
100
4 participants
@kbrosnan @gabrielluong @Mugurell @sarah541