Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #23738 - Integrate the Contile top sites updater #23781

Merged
merged 2 commits into from
Feb 23, 2022
Merged

For #23738 - Integrate the Contile top sites updater #23781

merged 2 commits into from
Feb 23, 2022

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Feb 16, 2022 •
edited
Loading

Fixes #23738. Depends on mozilla-mobile/android-components#11721

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong added the pr:needs-ac-bump PR that needs a AC bump label Feb 16, 2022
@gabrielluong gabrielluong requested review from a team as code owners February 16, 2022 15:38
@gabrielluong gabrielluong mentioned this pull request Feb 16, 2022
Merged
4 tasks
@gabrielluong gabrielluong force-pushed the 23738 branch 2 times, most recently from 0dd22da to 4d45556 Compare February 16, 2022 16:04
@gabrielluong gabrielluong mentioned this pull request Feb 18, 2022
Closed
@gabrielluong gabrielluong added needs:review PRs that need to be reviewed and removed pr:needs-ac-bump PR that needs a AC bump labels Feb 19, 2022
@gabrielluong gabrielluong force-pushed the 23738 branch 2 times, most recently from 6189260 to 612a6fd Compare February 21, 2022 06:45
@gabrielluong gabrielluong reopened this Feb 22, 2022
@gabrielluong gabrielluong reopened this Feb 22, 2022
@gabrielluong gabrielluong force-pushed the 23738 branch 4 times, most recently from 45de637 to a54f583 Compare February 23, 2022 19:52
csadilek
csadilek approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now with the new refreshTopSitesIfCacheExpired. 🚢 it.

@gabrielluong gabrielluong added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Feb 23, 2022
@mergify mergify bot merged commit 783d203 into mozilla-mobile:main Feb 23, 2022
@gabrielluong gabrielluong deleted the 23738 branch February 23, 2022 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csadilek csadilek csadilek approved these changes

Assignees

@csadilek csadilek

Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate the Contile top sites updater
2 participants
@gabrielluong @csadilek