Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Issue #11698: Add an updater to periodically fetch the Contile Top Sites #11721

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Issue #11698: Add an updater to periodically fetch the Contile Top Sites #11721

merged 2 commits into from
Feb 18, 2022

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Feb 14, 2022 •
edited
Loading

Fixes #11698. Fenix integration mozilla-mobile/fenix#23781.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@gabrielluong gabrielluong added the 🕵️‍♀️ needs review PRs that need to be reviewed label Feb 14, 2022
@gabrielluong gabrielluong requested review from grigoryk and a team as code owners February 14, 2022 23:24
@gabrielluong gabrielluong removed the request for review from grigoryk February 14, 2022 23:25
@gabrielluong gabrielluong force-pushed the 11698 branch 2 times, most recently from 68e3f52 to 8425113 Compare February 15, 2022 06:05
@gabrielluong gabrielluong reopened this Feb 15, 2022
@gabrielluong gabrielluong mentioned this pull request Feb 16, 2022
Merged
3 tasks
@csadilek csadilek requested a review from Amejia481 February 16, 2022 15:56
@gabrielluong gabrielluong mentioned this pull request Feb 16, 2022
Closed
@gabrielluong gabrielluong force-pushed the 11698 branch 2 times, most recently from ab606d4 to 79a980e Compare February 17, 2022 21:40
csadilek
csadilek reviewed Feb 17, 2022
View reviewed changes
.../service/contile/src/main/java/mozilla/components/service/contile/ContileTopSitesProvider.kt
private val client: Client,
private val endPointURL: String = CONTILE_ENDPOINT_URL,
private val maxCacheAgeInMinutes: Long = -1
) : TopSitesProvider {

private val applicationContext = context.applicationContext
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me now with the context things figure out! Did you want to address / handle mozilla-mobile/fenix#23781 (comment) here as well or in a separate PR. I think the Fenix integration is dependent on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am gonna do that separately.

@gabrielluong gabrielluong added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 17, 2022
@mergify mergify bot merged commit 300df48 into mozilla-mobile:main Feb 18, 2022
@gabrielluong gabrielluong deleted the 11698 branch February 18, 2022 00:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csadilek csadilek csadilek left review comments

@Amejia481 Amejia481 Amejia481 approved these changes

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an updater to periodically fetch the Contile Top Sites
3 participants
@gabrielluong @csadilek @Amejia481