Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11044 - Sets the anchorView of the snackbar to be the new tab fab #11930

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

boek
Copy link
Contributor

@boek boek commented Jun 25, 2020

image

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@boek boek requested a review from darkwing June 25, 2020 00:16
@boek
Copy link
Contributor Author

boek commented Jun 25, 2020

@AmyYLee With both the snackbar and the fab visible at the same time it you can tell that they are two different shades of purple. Is this okay?

@boek boek requested a review from AmyYLee June 25, 2020 00:17
@darkwing
Copy link
Contributor

I'm cool with this. We also need to do this for close all, save to collection, etc.

@AmyYLee
Copy link
Collaborator

AmyYLee commented Jun 25, 2020

@AmyYLee With both the snackbar and the fab visible at the same time it you can tell that they are two different shades of purple. Is this okay?

@boek @darkwing Hi, these are actually suppose to be the same colour, Violet 50 (#9059ff). This applies to all buttons, toggles, and snackbars in dark theme. We only use Violet 40 (#AB71FF) on text links in dark theme. Thanks!

@boek boek force-pushed the i11044 branch 2 times, most recently from 2571a27 to 2bdbec5 Compare June 27, 2020 00:00
@darkwing darkwing added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jun 27, 2020
@liuche liuche merged commit a18c1be into mozilla-mobile:master Jun 27, 2020
@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
@boek boek deleted the i11044 branch July 7, 2020 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants