Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Undo snackbar pushes FAB up in the new tab tray #11089

Closed
miDeb opened this issue May 30, 2020 · 2 comments
Closed

[Bug] Undo snackbar pushes FAB up in the new tab tray #11089

miDeb opened this issue May 30, 2020 · 2 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Tabs

Comments

@miDeb
Copy link
Contributor

miDeb commented May 30, 2020

Steps to reproduce

  • Open a new tab
  • Close the tab

Expected behavior

The FAB stays at the same position

Actual behavior

The FAB is pushed up by the snackbar, the "undo" button is now at its position. This is counterintuitive, as opening a new tab is a very common action and users will build up muscle memory for tapping that button. Therefore, I believe that the FAB should always have a fixed position on screen.
Also, this violates the Material Design spec:

Don’t animate other components along with snackbar animations, such as the floating action button.

Device information

  • Android device: Samsung Galaxy A50
  • Fenix version: Nightly 200530 06:01

┆Issue is synchronized with this Jira Task

@miDeb miDeb added the 🐞 bug Crashes, Something isn't working, .. label May 30, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 30, 2020
@ekager ekager added Feature:Tabs and removed needs:triage Issue needs triage labels May 30, 2020
@astarq
Copy link

astarq commented May 30, 2020

The snackbar is also a bit low down, my phone has curved corners and the snackbar is slightly hidden under them now
Device: Galaxy S8

@liuche liuche added the Skittle label Jun 1, 2020
@miDeb
Copy link
Contributor Author

miDeb commented Jun 27, 2020

Fixed by #11930.

@miDeb miDeb closed this as completed Jun 27, 2020
@data-sync-user data-sync-user changed the title [Bug] Undo snackbar pushes FAB up in the new tab tray FNX-11953 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX-11953 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray FNX2-16330 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16330 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray FNX3-14382 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14382 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray FNX-11953 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-11953 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray FNX2-16330 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16330 ⁃ [Bug] Undo snackbar pushes FAB up in the new tab tray [Bug] Undo snackbar pushes FAB up in the new tab tray May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Tabs
Projects
None yet
Development

No branches or pull requests

5 participants