This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fixes #11672, #11727: Delete default tab text and add padding to infinite character #11738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
hkaancaliskan
changed the title
BranescuMihai
suggested changes
Jun 19, 2020
app/src/main/java/org/mozilla/fenix/components/toolbar/TabCounter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/components/toolbar/TabCounter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/components/toolbar/TabCounter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/components/toolbar/TabCounter.kt
Outdated
Show resolved
Hide resolved
Fixes #11672, #11727: Empty default tab text and add padding to infinite character Fixes #11739: Fix flicker Update TabCounter.kt make lint happy don't animate unnecessarily don't animate unnecessarily Fixes #11739: Fix flicker Update TabCounter.kt squash commits don't animate unnecessarily Fixes #11672, #11727: Empty default tab text and add padding to infinite character Fixes #11739: Fix flicker Update TabCounter.kt make lint happy don't animate unnecessarily
4 tasks
|
Thanks for the fix @hakkikaancaliskan, looks good! Re-opened to run the tests (#11878) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11672, #11727, #11739
For #11727:
For #11672:
Pull Request checklist
After merge
To download an APK when reviewing a PR: