[Bug] Tab counter flickers

[hkaancaliskan]

Put Log.d() to necessary lines to watch count.

fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/TabCounter.kt

Line 53 in 54d7fc1

if (this.count == 0) {

Open new tab, go home, open tab tray, tap to addTab fab etc. Watch changes of this.count.

Looks like this.count reset to 0 while navigating, thus setCount() works on every newTab fab pressing and this causes flicker.

┆Issue is synchronized with this Jira Task

[hkaancaliskan]

Looks like we need to save tab count somewhere out of there to prevent resetting.
I'm unable to do this. Whoever wants this issue can take.

[hkaancaliskan]

Properly handling this.count doesn't solve issue. Looks like problem is something another. Investigating.

[hkaancaliskan]

Fixed issue.
Tab counter init was adding 3dp top and right padding, idk why.
This padding causing the flicker.
I've changed it.

[gabrielluong]

Fixed issue.
Tab counter init was adding 3dp top and right padding, idk why.
This padding causing the flicker.
I've changed it.

@hakkikaancaliskan Would you be available to also upstream these changes to android-components? https://github.com/mozilla-mobile/android-components/blob/ca3eff8a75ec791d718e5ceddc03285c8357836e/components/ui/tabcounter/src/main/java/mozilla/components/ui/tabcounter/TabCounter.kt

Ideally, we would always use the components from android-components since it is meant to be re-usable beyond Fenix. We have another issue mozilla-mobile/android-components#2743 to eventually upstream all the downstream Fenix changes to the android-components and remove the duplication in Fenix. You can build the sample-browser in the android-components repo to test any TabCounter changes.

[hkaancaliskan]

Fixed issue.
Tab counter init was adding 3dp top and right padding, idk why.
This padding causing the flicker.
I've changed it.

@hakkikaancaliskan Would you be available to also upstream these changes to android-components? https://github.com/mozilla-mobile/android-components/blob/ca3eff8a75ec791d718e5ceddc03285c8357836e/components/ui/tabcounter/src/main/java/mozilla/components/ui/tabcounter/TabCounter.kt

Ideally, we would always use the components from android-components since it is meant to be re-usable beyond Fenix. We have another issue mozilla-mobile/android-components#2743 to eventually upstream all the downstream Fenix changes to the android-components and remove the duplication in Fenix. You can build the sample-browser in the android-components repo to test any TabCounter changes.

I've done this in a gist because I'm not good at components. Is this enough or need more work?
https://gist.github.com/hakkikaancaliskan/d11a07c5a963051b28498fdba1a1c06a

[gabrielluong]

Fixed issue.
Tab counter init was adding 3dp top and right padding, idk why.
This padding causing the flicker.
I've changed it.

@hakkikaancaliskan Would you be available to also upstream these changes to android-components? https://github.com/mozilla-mobile/android-components/blob/ca3eff8a75ec791d718e5ceddc03285c8357836e/components/ui/tabcounter/src/main/java/mozilla/components/ui/tabcounter/TabCounter.kt
Ideally, we would always use the components from android-components since it is meant to be re-usable beyond Fenix. We have another issue mozilla-mobile/android-components#2743 to eventually upstream all the downstream Fenix changes to the android-components and remove the duplication in Fenix. You can build the sample-browser in the android-components repo to test any TabCounter changes.

I've done this in a gist because I'm not good at components. Is this enough or need more work?
https://gist.github.com/hakkikaancaliskan/d11a07c5a963051b28498fdba1a1c06a

Ideally, a PR for components so that it could be reviewed and landed by a peer. Feel free to reach out on https://chat.mozilla.org/#/room/#android-components:mozilla.org if you need help.

[hkaancaliskan]

Fixed issue.
Tab counter init was adding 3dp top and right padding, idk why.
This padding causing the flicker.
I've changed it.

@hakkikaancaliskan Would you be available to also upstream these changes to android-components? https://github.com/mozilla-mobile/android-components/blob/ca3eff8a75ec791d718e5ceddc03285c8357836e/components/ui/tabcounter/src/main/java/mozilla/components/ui/tabcounter/TabCounter.kt
Ideally, we would always use the components from android-components since it is meant to be re-usable beyond Fenix. We have another issue mozilla-mobile/android-components#2743 to eventually upstream all the downstream Fenix changes to the android-components and remove the duplication in Fenix. You can build the sample-browser in the android-components repo to test any TabCounter changes.

I've done this in a gist because I'm not good at components. Is this enough or need more work?
https://gist.github.com/hakkikaancaliskan/d11a07c5a963051b28498fdba1a1c06a

Ideally, a PR for components so that it could be reviewed and landed by a peer. Feel free to reach out on https://chat.mozilla.org/#/room/#android-components:mozilla.org if you need help.

Opened pr, mozilla-mobile/android-components#7446