Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #10453: Add item decoration after setAdapter() is called. #10476

Closed
wants to merge 1 commit into from
Closed

For #10453: Add item decoration after setAdapter() is called. #10476

wants to merge 1 commit into from

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented May 7, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcarare
For mozilla-mobile#10453: Add item decoration after setAdapter() is c…
cd49ad3 
…alled.

Applying item decoration needs to be done after setAdapter() is called
because it affects measurement of items views.
@mcarare
Copy link
Contributor Author

mcarare commented May 7, 2020

@boek, @darkwing I think this should be a quick solution for fixing the nightlies, but IMO a more elegant and safe solution would be adding item decoration as a parameter in BrowserTabsTray. I already put up a PR in AC for this: mozilla-mobile/android-components#6896

@mcarare mcarare mentioned this pull request May 7, 2020
Merged
4 tasks
@mcarare
Copy link
Contributor Author

mcarare commented May 7, 2020

Fix already merged in #10495

@mcarare mcarare closed this May 7, 2020
@mcarare mcarare deleted the 10453 branch June 3, 2020 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcarare